linux-kernel - Re: [PATCH] pwm: mtk-disp: Fix the parameters calculated by the enabled flag of disp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <814291c8-e24f-ea5c-8f88-af978f72e335@collabora.com>
Date:   Tue, 30 Aug 2022 12:36:48 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     xinlei.lee@...iatek.com, thierry.reding@...il.com,
        u.kleine-koenig@...gutronix.de, matthias.bgg@...il.com,
        jitao.shi@...iatek.com
Cc:     linux-pwm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH] pwm: mtk-disp: Fix the parameters calculated by the
 enabled flag of disp_pwm.

Il 29/08/22 06:04, xinlei.lee@...iatek.com ha scritto:
> From: xinlei lee <xinlei.lee@...iatek.com>
> 
> In the original mtk_disp_pwm_get_state() function, the result of reading
> con0 & BIT(0) is enabled as disp_pwm.
> In order to conform to the register table, we should use the disp_pwm
> base address as the enabled judgment.
> 
> Fixes: 3f2b16734914 ("pwm: mtk-disp: Implement atomic API .get_state()")
> 
> Signed-off-by: xinlei lee <xinlei.lee@...iatek.com>
> Reviewed-by: Miles Chen <miles.chen@...iatek.com>

This fix is valid for all MediaTek SoCs that are currently supported in
pwm-mtk-disp (and some others that aren't supported yet).

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>