linux-kernel - Re: [PATCH v1 3/4] usb: typec: tcpci_maxim: Export helper function for register reads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yw3tLf6lcmtU1+t/@kuha.fi.intel.com>
Date:   Tue, 30 Aug 2022 13:57:49 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Badhri Jagan Sridharan <badhri@...gle.com>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Kyle Tso <kyletso@...gle.com>
Subject: Re: [PATCH v1 3/4] usb: typec: tcpci_maxim: Export helper function
 for register reads

Hi Badhri,

On Fri, Aug 26, 2022 at 01:40:00AM -0700, Badhri Jagan Sridharan wrote:
> Signed-off-by: Badhri Jagan Sridharan <badhri@...gle.com>

No commit message? I guess you want to do this because you want to
split the driver into several files. Please put that into your commit
message.

> ---
>  drivers/usb/typec/tcpm/tcpci_maxim.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpci_maxim.c b/drivers/usb/typec/tcpm/tcpci_maxim.c
> index 4b6705f3d7b7..af3a7ecab23b 100644
> --- a/drivers/usb/typec/tcpm/tcpci_maxim.c
> +++ b/drivers/usb/typec/tcpm/tcpci_maxim.c
> @@ -68,25 +68,29 @@ static struct max_tcpci_chip *tdata_to_max_tcpci(struct tcpci_data *tdata)
>  	return container_of(tdata, struct max_tcpci_chip, data);
>  }
>  
> -static int max_tcpci_read16(struct max_tcpci_chip *chip, unsigned int reg, u16 *val)
> +inline int max_tcpci_read16(struct max_tcpci_chip *chip, unsigned int reg, u16 *val)
>  {
>  	return regmap_raw_read(chip->data.regmap, reg, val, sizeof(u16));
>  }
> +EXPORT_SYMBOL_GPL(max_tcpci_read16);

Hold on! You don't need to export these under any circumstance.

If you want to make these inline function, move them to a header.
Otherwise just make them non-static.

Either way, don't export them.

> -static int max_tcpci_write16(struct max_tcpci_chip *chip, unsigned int reg, u16 val)
> +inline int max_tcpci_write16(struct max_tcpci_chip *chip, unsigned int reg, u16 val)
>  {
>  	return regmap_raw_write(chip->data.regmap, reg, &val, sizeof(u16));
>  }
> +EXPORT_SYMBOL_GPL(max_tcpci_write16);
>  
> -static int max_tcpci_read8(struct max_tcpci_chip *chip, unsigned int reg, u8 *val)
> +inline int max_tcpci_read8(struct max_tcpci_chip *chip, unsigned int reg, u8 *val)
>  {
>  	return regmap_raw_read(chip->data.regmap, reg, val, sizeof(u8));
>  }
> +EXPORT_SYMBOL_GPL(max_tcpci_read8);
>  
> -static int max_tcpci_write8(struct max_tcpci_chip *chip, unsigned int reg, u8 val)
> +inline int max_tcpci_write8(struct max_tcpci_chip *chip, unsigned int reg, u8 val)
>  {
>  	return regmap_raw_write(chip->data.regmap, reg, &val, sizeof(u8));
>  }
> +EXPORT_SYMBOL_GPL(max_tcpci_write8);
>  
>  static void max_tcpci_init_regs(struct max_tcpci_chip *chip)
>  {
> -- 
> 2.37.2.672.g94769d06f0-goog

-- 
heikki