linux-kernel - RE: [PATCH v3 07/14] iio: ltc2688: Simplify using devm_regulator_*get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SN4PR03MB6784F7C3B98332410CC97F0499799@SN4PR03MB6784.namprd03.prod.outlook.com>
Date:   Tue, 30 Aug 2022 11:34:26 +0000
From:   "Sa, Nuno" <Nuno.Sa@...log.com>
To:     Matti Vaittinen <mazziesaccount@...il.com>,
        Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
CC:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 07/14] iio: ltc2688: Simplify using
 devm_regulator_*get_enable()

> From: Matti Vaittinen <mazziesaccount@...il.com>
> Sent: Friday, August 19, 2022 9:19 PM
> To: Matti Vaittinen <mazziesaccount@...il.com>; Matti Vaittinen
> <matti.vaittinen@...rohmeurope.com>
> Cc: Sa, Nuno <Nuno.Sa@...log.com>; Jonathan Cameron
> <jic23@...nel.org>; Lars-Peter Clausen <lars@...afoo.de>; linux-
> iio@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH v3 07/14] iio: ltc2688: Simplify using
> devm_regulator_*get_enable()
> 
> [External]
> 
> Use devm_regulator_bulk_get_enable() instead of open coded bulk-
> get,
> bulk-enable, add-action-to-disable-at-detach - pattern.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>
> 

FWIW, I also don't care that much about the whole variable scope
discussion... Hence, with the change requested by Jonathan:

Reviewed-by: Nuno Sá <nuno.sa@...log.com>