linux-kernel - Re: [PATCH 1/3] scripts/gdb: fix lx-timerlist for struct timequeue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52c33fc7-220e-c05e-3ad9-028095d8705d@siemens.com>
Date:   Wed, 31 Aug 2022 17:00:59 +0200
From:   Jan Kiszka <jan.kiszka@...mens.com>
To:     <pngliu@...mail.com>, <kbingham@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
CC:     <linux-kernel@...r.kernel.org>, Peng Liu <liupeng17@...ovo.com>,
        "Stephen Boyd" <swboyd@...omium.org>
Subject: Re: [PATCH 1/3] scripts/gdb: fix lx-timerlist for struct
 timequeue_head change

On 20.07.22 14:27, pngliu@...mail.com wrote:
> From: Peng Liu <liupeng17@...ovo.com>
> 
> commit 511885d7061e ("lib/timerqueue: Rely on rbtree semantics for next
> timer") changed struct timerqueue_head, and so print_active_timers()
> should be changed accordingly with its way to interpret the structure.
> 
> Signed-off-by: Peng Liu <liupeng17@...ovo.com>
> ---
>  scripts/gdb/linux/timerlist.py | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/scripts/gdb/linux/timerlist.py b/scripts/gdb/linux/timerlist.py
> index 071d0dd5a634..44e39dc3eb64 100644
> --- a/scripts/gdb/linux/timerlist.py
> +++ b/scripts/gdb/linux/timerlist.py
> @@ -43,8 +43,7 @@ def print_timer(rb_node, idx):
>  
>  
>  def print_active_timers(base):
> -    curr = base['active']['next']['node']
> -    curr = curr.address.cast(rbtree.rb_node_type.get_type().pointer())
> +    curr = base['active']['rb_root']['rb_leftmost']
>      idx = 0
>      while curr:
>          yield print_timer(curr, idx)

Looks good to me.

Reviewed-by: Jan Kiszka <jan.kiszka@...mens.com>

Jan

-- 
Siemens AG, Technology
Competence Center Embedded Linux