linux-kernel - Re: [PATCH v2] vduse: prevent uninitialized memory accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 31 Aug 2022 11:46:11 -0400
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Maxime Coquelin <maxime.coquelin@...hat.com>
Cc:     jasowang@...hat.com, Greg KH <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, elic@...dia.com,
        guanjun@...ux.alibaba.com, parav@...dia.com,
        gautam.dawar@...inx.com, dan.carpenter@...cle.com,
        xieyongji@...edance.com, stable@...r.kernel.org
Subject: Re: [PATCH v2] vduse: prevent uninitialized memory accesses

On Wed, Aug 31, 2022 at 05:01:11PM +0200, Maxime Coquelin wrote:
> On 8/29/22 09:48, Greg KH wrote:
> > On Mon, Aug 29, 2022 at 09:34:24AM +0200, Maxime Coquelin wrote:
> > > If the VDUSE application provides a smaller config space
> > > than the driver expects, the driver may use uninitialized
> > > memory from the stack.
> > > 
> > > This patch prevents it by initializing the buffer passed by
> > > the driver to store the config value.
> > > 
> > > This fix addresses CVE-2022-2308.
> > > 
> > > Cc: xieyongji@...edance.com
> > > Cc: stable@...r.kernel.org # v5.15+
> > > Fixes: c8a6153b6c59 ("vduse: Introduce VDUSE - vDPA Device in Userspace")
> > > 
> > > Acked-by: Jason Wang <jasowang@...hat.com>
> > > Signed-off-by: Maxime Coquelin <maxime.coquelin@...hat.com>
> > 
> > Please no blank line above the Acked-by: line here if possible.
> 
> Sure.
> 
> Jason, do you prefer I post a new revision with this single change or
> you will handle it while applying? Either way is fine to me.
> 
> Thanks,
> Maxime

I queue these normally.

> > thanks,
> > 
> > greg k-h
> >