linux-kernel - Re: [PATCH v2 1/2] libfs: Introduce tokenize_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c27b6b3-2d3c-d750-58ad-bd35ede421f6@intel.com>
Date:   Wed, 31 Aug 2022 18:15:32 +0200
From:   Cezary Rojewski <cezary.rojewski@...el.com>
To:     Matthew Wilcox <willy@...radead.org>
CC:     <alsa-devel@...a-project.org>, <broonie@...nel.org>,
        <tiwai@...e.com>, <perex@...ex.cz>,
        <amadeuszx.slawinski@...ux.intel.com>,
        <pierre-louis.bossart@...ux.intel.com>, <hdegoede@...hat.com>,
        <lgirdwood@...il.com>, <kai.vehmanen@...ux.intel.com>,
        <peter.ujfalusi@...ux.intel.com>,
        <ranjani.sridharan@...ux.intel.com>,
        <yung-chuan.liao@...ux.intel.com>, <viro@...iv.linux.org.uk>,
        <linux-fsdevel@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <andy.shevchenko@...il.com>
Subject: Re: [PATCH v2 1/2] libfs: Introduce tokenize_user_input()

On 2022-08-30 8:33 PM, Matthew Wilcox wrote:
> On Thu, Aug 25, 2022 at 06:48:32PM +0200, Cezary Rojewski wrote:
>> Add new helper function to allow for splitting specified user string
>> into a sequence of integers. Internally it makes use of get_options() so
>> the returned sequence contains the integers extracted plus an additional
>> element that begins the sequence and specifies the integers count.
>>
>> Suggested-by: Andy Shevchenko <andy.shevchenko@...il.com>
>> Signed-off-by: Cezary Rojewski <cezary.rojewski@...el.com>
>> ---
>>   fs/libfs.c         | 45 +++++++++++++++++++++++++++++++++++++++++++++
>>   include/linux/fs.h |  1 +
> 
> This really has nothing to do with filesystems.  Surely
> string_helpers.[ch] is the appropriate place for this code?
> Also get_options() should probably move its prototype from kernel.h to
> string_helpers.h.


Hello Matthew,

Thanks for your input. The initial version of the change was located in 
the string_helpers.[ch] just like you propose and I have no problem 
moving it back again. string_helpers are devoid of __user content though 
and that's why in v2 it's part of libfs instead.

I'll give a day or two to see if there are other suggestions and then 
send v3 relocating the implementation.


Regards,
Czarek