linux-kernel - [PATCH] remoteproc: report firmware name on load failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220831161736.749932-1-krzysztof.kozlowski@linaro.org>
Date:   Wed, 31 Aug 2022 19:17:36 +0300
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Bjorn Andersson <andersson@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: [PATCH] remoteproc: report firmware name on load failures

remoteproc error messages like:
  remoteproc remoteproc0: request_firmware failed: -2
  remoteproc remoteproc1: request_firmware failed: -2
are difficult to debug as one actually have no clue which device
reported it and which firmware is missing.  Be verbose and print the
name of the failed firmware.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
---
 drivers/remoteproc/remoteproc_core.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index e5279ed9a8d7..71cd7ed7a970 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -1923,7 +1923,8 @@ int rproc_trigger_recovery(struct rproc *rproc)
 	/* load firmware */
 	ret = request_firmware(&firmware_p, rproc->firmware, dev);
 	if (ret < 0) {
-		dev_err(dev, "request_firmware failed: %d\n", ret);
+		dev_err(dev, "request_firmware %s failed: %d\n",
+			rproc->firmware, ret);
 		goto unlock_mutex;
 	}
 
@@ -2023,7 +2024,8 @@ int rproc_boot(struct rproc *rproc)
 		/* load firmware */
 		ret = request_firmware(&firmware_p, rproc->firmware, dev);
 		if (ret < 0) {
-			dev_err(dev, "request_firmware failed: %d\n", ret);
+			dev_err(dev, "request_firmware %s failed: %d\n",
+				rproc->firmware, ret);
 			goto downref_rproc;
 		}
 
-- 
2.34.1