linux-kernel - Re: [PATCH] ASoC: max98390: Remove unnecessary amp on/off conrtol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yw+OCnOgYUOWdIEx@sirena.org.uk>
Date:   Wed, 31 Aug 2022 17:36:26 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Steve Lee <steve.lee.analog@...il.com>
Cc:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
        krzk@...nel.org, ryans.lee@...log.com
Subject: Re: [PATCH] ASoC: max98390: Remove unnecessary amp on/off conrtol

On Fri, Aug 26, 2022 at 11:35:04AM +0900, Steve Lee wrote:

>  The Amp is already control in userspace before trigger calibrate function.
> Remove unnecessary control in calibrate function.

I can't see anything which ensures that this is the case?  Should there
be a check which returns an error if the output is not enabled, or
should the function check the current state and preserve it at the end?
I can see that this would fix problems with it being disabled when
callibrating.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)