linux-kernel - Re: [PATCH v3] vduse: prevent uninitialized memory accesses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fc475f95-3523-6c03-2508-23617eb26422@nvidia.com>
Date:   Wed, 31 Aug 2022 16:57:59 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Maxime Coquelin <maxime.coquelin@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        Eli Cohen <elic@...dia.com>,
        "guanjun@...ux.alibaba.com" <guanjun@...ux.alibaba.com>,
        Parav Pandit <parav@...dia.com>,
        "gautam.dawar@...inx.com" <gautam.dawar@...inx.com>,
        "dan.carpenter@...cle.com" <dan.carpenter@...cle.com>,
        "xieyongji@...edance.com" <xieyongji@...edance.com>,
        "jasowang@...hat.com" <jasowang@...hat.com>,
        "mst@...hat.com" <mst@...hat.com>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH v3] vduse: prevent uninitialized memory accesses

On 8/31/22 08:49, Maxime Coquelin wrote:
> If the VDUSE application provides a smaller config space
> than the driver expects, the driver may use uninitialized
> memory from the stack.
> 
> This patch prevents it by initializing the buffer passed by
> the driver to store the config value.
> 
> This fix addresses CVE-2022-2308.
> 
> Cc: stable@...r.kernel.org # v5.15+
> Fixes: c8a6153b6c59 ("vduse: Introduce VDUSE - vDPA Device in Userspace")
> Reviewed-by: Xie Yongji <xieyongji@...edance.com>
> Acked-by: Jason Wang <jasowang@...hat.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@...hat.com>
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>