linux-kernel - Re: [PATCH 2/2] arm64: remove unneed defer_reserve_crashkernel() and crash_mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 31 Aug 2022 09:51:25 +0800
From:   "Leizhen (ThunderTown)" <thunder.leizhen@...wei.com>
To:     Baoquan He <bhe@...hat.com>, <linux-kernel@...r.kernel.org>
CC:     <linux-arm-kernel@...ts.infradead.org>, <catalin.marinas@....com>,
        <ardb@...nel.org>, <rppt@...nel.org>,
        <guanghuifeng@...ux.alibaba.com>, <mark.rutland@....com>,
        <will@...nel.org>, <linux-mm@...ck.org>,
        <wangkefeng.wang@...wei.com>, <kexec@...ts.infradead.org>
Subject: Re: [PATCH 2/2] arm64: remove unneed defer_reserve_crashkernel() and
 crash_mem_map



On 2022/8/28 8:55, Baoquan He wrote:
> Now they are not needed any more, clean them up.

Reviewed-by: Zhen Lei <thunder.leizhen@...wei.com>

> 
> Signed-off-by: Baoquan He <bhe@...hat.com>
> ---
>  arch/arm64/include/asm/memory.h |  5 -----
>  arch/arm64/mm/mmu.c             | 15 ---------------
>  2 files changed, 20 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h
> index 9dd08cd339c3..b9e71583c9cb 100644
> --- a/arch/arm64/include/asm/memory.h
> +++ b/arch/arm64/include/asm/memory.h
> @@ -363,11 +363,6 @@ static inline void *phys_to_virt(phys_addr_t x)
>  })
>  
>  void dump_mem_limit(void);
> -
> -static inline bool defer_reserve_crashkernel(void)
> -{
> -	return IS_ENABLED(CONFIG_ZONE_DMA) || IS_ENABLED(CONFIG_ZONE_DMA32);
> -}
>  #endif /* !ASSEMBLY */
>  
>  /*
> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
> index cdd338fa2115..c3f8f426c3d8 100644
> --- a/arch/arm64/mm/mmu.c
> +++ b/arch/arm64/mm/mmu.c
> @@ -502,21 +502,6 @@ void __init mark_linear_text_alias_ro(void)
>  			    PAGE_KERNEL_RO);
>  }
>  
> -static bool crash_mem_map __initdata;
> -
> -static int __init enable_crash_mem_map(char *arg)
> -{
> -	/*
> -	 * Proper parameter parsing is done by reserve_crashkernel(). We only
> -	 * need to know if the linear map has to avoid block mappings so that
> -	 * the crashkernel reservations can be unmapped later.
> -	 */
> -	crash_mem_map = true;
> -
> -	return 0;
> -}
> -early_param("crashkernel", enable_crash_mem_map);
> -
>  static void __init map_mem(pgd_t *pgdp)
>  {
>  	static const u64 direct_map_end = _PAGE_END(VA_BITS_MIN);
> 

-- 
Regards,
  Zhen Lei