linux-kernel - RE: [PATCH] drm/amd/display: fix indentation in commit_planes_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BL1PR12MB5144CE167DC191E105C43BBAF7789@BL1PR12MB5144.namprd12.prod.outlook.com>
Date:   Wed, 31 Aug 2022 18:03:49 +0000
From:   "Deucher, Alexander" <Alexander.Deucher@....com>
To:     "Mahfooz, Hamza" <Hamza.Mahfooz@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "Wentland, Harry" <Harry.Wentland@....com>,
        "Li, Sun peng (Leo)" <Sunpeng.Li@....com>,
        "Siqueira, Rodrigo" <Rodrigo.Siqueira@....com>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        "Kazlauskas, Nicholas" <Nicholas.Kazlauskas@....com>,
        "Lei, Jun" <Jun.Lei@....com>,
        "Somasundaram, Meenakshikumar" <Meenakshikumar.Somasundaram@....com>,
        "Lee, Alvin" <Alvin.Lee2@....com>,
        "Leung, Martin" <Martin.Leung@....com>,
        "Tam, Samson" <Samson.Tam@....com>,
        "Hung, Alex" <Alex.Hung@....com>,
        "Aberback, Joshua" <Joshua.Aberback@....com>,
        "Liu, Wenjing" <Wenjing.Liu@....com>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>
Subject: RE: [PATCH] drm/amd/display: fix indentation in
 commit_planes_for_stream()

[AMD Official Use Only - General]

> -----Original Message-----
> From: Mahfooz, Hamza <Hamza.Mahfooz@....com>
> Sent: Wednesday, August 31, 2022 1:58 PM
> To: linux-kernel@...r.kernel.org
> Cc: Mahfooz, Hamza <Hamza.Mahfooz@....com>; Wentland, Harry
> <Harry.Wentland@....com>; Li, Sun peng (Leo) <Sunpeng.Li@....com>;
> Siqueira, Rodrigo <Rodrigo.Siqueira@....com>; Deucher, Alexander
> <Alexander.Deucher@....com>; Koenig, Christian
> <Christian.Koenig@....com>; Pan, Xinhui <Xinhui.Pan@....com>; David
> Airlie <airlied@...ux.ie>; Daniel Vetter <daniel@...ll.ch>; Kazlauskas,
> Nicholas <Nicholas.Kazlauskas@....com>; Lei, Jun <Jun.Lei@....com>;
> Somasundaram, Meenakshikumar
> <Meenakshikumar.Somasundaram@....com>; Lee, Alvin
> <Alvin.Lee2@....com>; Leung, Martin <Martin.Leung@....com>; Tam,
> Samson <Samson.Tam@....com>; Hung, Alex <Alex.Hung@....com>;
> Aberback, Joshua <Joshua.Aberback@....com>; Liu, Wenjing
> <Wenjing.Liu@....com>; amd-gfx@...ts.freedesktop.org; dri-
> devel@...ts.freedesktop.org
> Subject: [PATCH] drm/amd/display: fix indentation in
> commit_planes_for_stream()
> 
> Address the following warning:
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this
> ‘if’ clause does not guard... [-Wmisleading-indentation]
>  3508 |         if (update_type != UPDATE_TYPE_FAST)
>       |         ^~
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17: note: ...this
> statement, but the latter is misleadingly indented as if it were guarded by the
> ‘if’
>  3510 |                 if (update_type != UPDATE_TYPE_FAST)
>       |                 ^~
> 
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@....com>

Acked-by: Alex Deucher <alexander.deucher@....com>

> ---
>  drivers/gpu/drm/amd/display/dc/core/dc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c
> b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index b49237390cce..6c4948916e7e 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -3505,11 +3505,11 @@ static void commit_planes_for_stream(struct dc
> *dc,
>  					top_pipe_to_program-
> >stream_res.tg);
>  		}
> 
> -	if (update_type != UPDATE_TYPE_FAST)
> +	if (update_type != UPDATE_TYPE_FAST) {
>  		dc->hwss.post_unlock_program_front_end(dc, context);
> -		if (update_type != UPDATE_TYPE_FAST)
> -			if (dc->hwss.commit_subvp_config)
> -				dc->hwss.commit_subvp_config(dc,
> context);
> +		if (dc->hwss.commit_subvp_config)
> +			dc->hwss.commit_subvp_config(dc, context);
> +	}
> 
>  	/* Since phantom pipe programming is moved to
> post_unlock_program_front_end,
>  	 * move the SubVP lock to after the phantom pipes have been setup
> --
> 2.37.2