linux-kernel - Re: [PATCH] Revert "iavf: Add waiting for response from PF in set mac"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 31 Aug 2022 11:31:29 -0700
From:   Tony Nguyen <anthony.l.nguyen@...el.com>
To:     Petr Oros <poros@...hat.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@...ts.osuosl.org>,
        "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Revert "iavf: Add waiting for response from PF in set
 mac"

On 8/30/2022 2:43 PM, Petr Oros wrote:
> This change caused a regressions with MAC address changing.
> It is not possible to simple fix issues caused by this patch.
> It is better revert/rework it.
> 
> [root@...t ~]# ethtool -i enp65s0f0
> driver: ice
> version: 5.19.4-200.fc36.x86_64
> firmware-version: 3.20 0x8000d83e 1.3146.0
> 
> - Change MAC for VF
> [root@...t ~]# echo 1 > /sys/class/net/enp65s0f0/device/sriov_numvfs
> [root@...t ~]# ip link set enp65s0f0v0 up
> [root@...t ~]# ip link set enp65s0f0v0 addr 00:11:22:33:44:55
> RTNETLINK answers: Permission denied
> 
> - Add VF to bond
> [root@...t ~]# echo 2 > /sys/class/net/enp65s0f0/device/sriov_numvfs
> [root@...t ~]# ip link add bond0 type bond
> [root@...t ~]# ip link set enp65s0f0v0 down
> [root@...t ~]# ip link set enp65s0f0v1 down
> [root@...t ~]# ip link set enp65s0f0v0 master bond0
> RTNETLINK answers: Permission denied
> dmesg:
> bond0: (slave enp65s0f0v1): Error -13 calling set_mac_address
> 
> This reverts commit 35a2443d0910fdd6ce29d4f724447ad7029e8f23.
> 
> Signed-off-by: Petr Oros <poros@...hat.com>

Hi Petr,

Could you see if this patch [1] resolves your issues?

Thanks,
Tony

[1] 
https://lore.kernel.org/intel-wired-lan/20220831135243.8623-1-mateusz.palczewski@intel.com/