linux-kernel - Re: [PATCH] thermal/drivers/da9062: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gpBco1OmKiMXm5fatFRuQYpCo5g8Cauh4S+BV+OxWJWw@mail.gmail.com>
Date:   Wed, 31 Aug 2022 21:00:19 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     zhaoxiao <zhaoxiao@...ontech.com>
Cc:     Support Opensource <support.opensource@...semi.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        "Zhang, Rui" <rui.zhang@...el.com>,
        Linux PM <linux-pm@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] thermal/drivers/da9062: Remove unnecessary print function dev_err()

On Fri, Aug 12, 2022 at 8:40 AM zhaoxiao <zhaoxiao@...ontech.com> wrote:
>
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> Signed-off-by: zhaoxiao <zhaoxiao@...ontech.com>
> ---
>  drivers/thermal/da9062-thermal.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/da9062-thermal.c b/drivers/thermal/da9062-thermal.c
> index 180edec34e07..7dcfde7a9f2c 100644
> --- a/drivers/thermal/da9062-thermal.c
> +++ b/drivers/thermal/da9062-thermal.c
> @@ -248,10 +248,9 @@ static int da9062_thermal_probe(struct platform_device *pdev)
>                 jiffies_to_msecs(thermal->zone->passive_delay_jiffies));
>
>         ret = platform_get_irq_byname(pdev, "THERMAL");
> -       if (ret < 0) {
> -               dev_err(&pdev->dev, "Failed to get platform IRQ.\n");
> +       if (ret < 0)
>                 goto err_zone;
> -       }
> +
>         thermal->irq = ret;
>
>         ret = request_threaded_irq(thermal->irq, NULL,
> --

Applied as 6.1 material with subject and changelog edits, thanks!