linux-kernel - Re: [PATCH v4 4/6] mfd: drivers: Add TI TPS65219 PMIC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220831190247.t46qdrwu4pe3woby@blmsp>
Date:   Wed, 31 Aug 2022 21:02:47 +0200
From:   Markus Schneider-Pargmann <msp@...libre.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Lee Jones <lee@...nel.org>, Tony Lindgren <tony@...mide.com>,
        nm@...com, kristo@...nel.org, Jerome Neanne <jneanne@...libre.com>,
        khilman@...libre.com, narmstrong@...libre.com, j-keerthy@...com,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-input@...r.kernel.org,
        linux-omap@...r.kernel.org
Subject: Re: [PATCH v4 4/6] mfd: drivers: Add TI TPS65219 PMIC support

Hi Krzysztof,

On Tue, Aug 30, 2022 at 12:46:53PM +0300, Krzysztof Kozlowski wrote:
> On 25/08/2022 18:02, Markus Schneider-Pargmann wrote:
> > From: Jerome Neanne <jneanne@...libre.com>
> > 
> > The TPS65219 is a power management IC PMIC designed to supply a wide
> > range of SoCs in both portable and stationary applications. Any SoC can
> > control TPS65219 over a standard I2C interface.
> > 
> > It contains the following components:
> > - Regulators.
> > - Over Temperature warning and Shut down.
> > - GPIOs
> > - Multi Function Pins (MFP)
> > - power-button
> > 
> > This patch adds support for tps65219 PMIC. At this time only
> > the functionalities listed below are made available:
> > 
> > - Regulators probe and functionalities
> > - warm and cold reset support
> > - SW shutdown support
> > - Regulator warnings via IRQs
> > - Power-button via IRQ
> > 
> > Signed-off-by: Jerome Neanne <jneanne@...libre.com>
> > Signed-off-by: Markus Schneider-Pargmann <msp@...libre.com>
> > ---
> > 
> > Notes:
> >     Changes in v4:
> >     - Removed unused fields from struct tps65219
> >     - Added description for the fields in struct tps65219
> >     - Fixed coding style
> >     - Squash all patches into one mfd patch
> >     - Call devm_mfd_add_devices multiple times to clean up the code
> >     - Remove debug prints and fixup other messages
> >     - Use new_probe instead of probe
> > 
> >  MAINTAINERS                  |   1 +
> >  drivers/mfd/Kconfig          |  14 ++
> >  drivers/mfd/Makefile         |   1 +
> >  drivers/mfd/tps65219.c       | 357 +++++++++++++++++++++++++++++++++++
> >  include/linux/mfd/tps65219.h | 345 +++++++++++++++++++++++++++++++++
> 
> Use subject prefixes matching the subsystem (git log --oneline -- ...).

thank you for noticing, I am fixing it for the next version.

Best,
Markus