linux-kernel - Re: [PATCH] cpuidle: move from strlcpy with unused retval to strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hOi8q65wz4FSjW0s9cWQhjUdNqiV=5n-Ef5hQKiJjB8w@mail.gmail.com>
Date:   Wed, 31 Aug 2022 21:11:00 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Linux PM <linux-pm@...r.kernel.org>,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH] cpuidle: move from strlcpy with unused retval to strscpy

On Thu, Aug 18, 2022 at 11:00 PM Wolfram Sang
<wsa+renesas@...g-engineering.com> wrote:
>
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
>  drivers/cpuidle/cpuidle-powernv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle-powernv.c b/drivers/cpuidle/cpuidle-powernv.c
> index c32c600b3cf8..0b5461b3d7dd 100644
> --- a/drivers/cpuidle/cpuidle-powernv.c
> +++ b/drivers/cpuidle/cpuidle-powernv.c
> @@ -233,8 +233,8 @@ static inline void add_powernv_state(int index, const char *name,
>                                      unsigned int exit_latency,
>                                      u64 psscr_val, u64 psscr_mask)
>  {
> -       strlcpy(powernv_states[index].name, name, CPUIDLE_NAME_LEN);
> -       strlcpy(powernv_states[index].desc, name, CPUIDLE_NAME_LEN);
> +       strscpy(powernv_states[index].name, name, CPUIDLE_NAME_LEN);
> +       strscpy(powernv_states[index].desc, name, CPUIDLE_NAME_LEN);
>         powernv_states[index].flags = flags;
>         powernv_states[index].target_residency = target_residency;
>         powernv_states[index].exit_latency = exit_latency;
> --

Applied as 6.1 material, thanks!