linux-kernel - Re: [PATCH 2/2] PM: move from strlcpy with unused retval to strscpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 31 Aug 2022 21:17:32 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Pavel Machek <pavel@....cz>, Len Brown <len.brown@...el.com>,
        Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 2/2] PM: move from strlcpy with unused retval to strscpy

On Thu, Aug 18, 2022 at 11:05 PM Wolfram Sang
<wsa+renesas@...g-engineering.com> wrote:
>
> Follow the advice of the below link and prefer 'strscpy' in this
> subsystem. Conversion is 1:1 because the return value is not used.
> Generated by a coccinelle script.
>
> Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
>  include/linux/suspend.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/suspend.h b/include/linux/suspend.h
> index 70f2921e2e70..23a253df7f6b 100644
> --- a/include/linux/suspend.h
> +++ b/include/linux/suspend.h
> @@ -75,7 +75,7 @@ extern struct suspend_stats suspend_stats;
>
>  static inline void dpm_save_failed_dev(const char *name)
>  {
> -       strlcpy(suspend_stats.failed_devs[suspend_stats.last_failed_dev],
> +       strscpy(suspend_stats.failed_devs[suspend_stats.last_failed_dev],
>                 name,
>                 sizeof(suspend_stats.failed_devs[0]));
>         suspend_stats.last_failed_dev++;
> --

Applied as 6.1 material, thanks!