linux-kernel - Re: [PATCH v2] hugetlb: use mm.h instead of mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 31 Aug 2022 12:37:22 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     linux-kernel@...r.kernel.org, Peter Xu <peterx@...hat.com>,
        Mike Kravetz <mike.kravetz@...cle.com>, linux-mm@...ck.org,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2] hugetlb: use mm.h instead of mm_types.h



On 8/31/22 12:27, Matthew Wilcox wrote:
> On Wed, Aug 31, 2022 at 11:57:39AM -0700, Randy Dunlap wrote:
>> mm_types.h does not have zap_flags_t in it so use mm.h instead
>> in hugetlb.h.
> 
> ... my copy of mm_types.h has zap_flags_t in it.  Was it recently moved?
> Perhaps moving it back is a better solution to this problem?

Ah, I see. This patch was originally to mmotm, but then for merging
(commit 05e90bd05eea), Peter Xu moved the typedef so that this patch
is not needed. Sorry for the noise.

and Thanks.

>> Fixes this build error:
>>
>> In file included from ../drivers/virt/nitro_enclaves/ne_misc_dev.c:16:0:
>> ../include/linux/hugetlb.h:414:4: error: unknown type name ‘zap_flags_t’; did you mean ‘vm_flags_t’?
>>     zap_flags_t zap_flags)
>>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Cc: Peter Xu <peterx@...hat.com>
>> Cc: Mike Kravetz <mike.kravetz@...cle.com>
>> Cc: linux-mm@...ck.org
>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>> Reviewed-by: Peter Xu <peterx@...hat.com>
>> ---
>> Fixes: mm-hugetlb-only-drop-uffd-wp-special-pte-if-required-fix.patch
>> v2: add Rev-by: Peter
>>     drop the bogus S-o-b: in Cc: Peter Xu
>>
>>  include/linux/hugetlb.h |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/include/linux/hugetlb.h
>> +++ b/include/linux/hugetlb.h
>> @@ -2,7 +2,7 @@
>>  #ifndef _LINUX_HUGETLB_H
>>  #define _LINUX_HUGETLB_H
>>  
>> -#include <linux/mm_types.h>
>> +#include <linux/mm.h>
>>  #include <linux/mmdebug.h>
>>  #include <linux/fs.h>
>>  #include <linux/hugetlb_inline.h>
>>

-- 
~Randy