linux-kernel - Re: [PATCH v2 1/2] gpio: Add gpio latch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202209010432.NKyeVosI-lkp@intel.com>
Date:   Thu, 1 Sep 2022 04:52:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sascha Hauer <s.hauer@...gutronix.de>, linux-gpio@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>, kernel@...gutronix.de,
        Sascha Hauer <s.hauer@...gutronix.de>
Subject: Re: [PATCH v2 1/2] gpio: Add gpio latch driver

Hi Sascha,

I love your patch! Yet something to improve:

[auto build test ERROR on brgl/gpio/for-next]
[also build test ERROR on linus/master v6.0-rc3 next-20220830]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sascha-Hauer/gpio-Add-gpio-latch-driver/20220831-135855
base:   https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/for-next
config: s390-randconfig-r021-20220831 (https://download.01.org/0day-ci/archive/20220901/202209010432.NKyeVosI-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/8fab8b8c35fd4faebb003751d6d34fc06093c19e
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Sascha-Hauer/gpio-Add-gpio-latch-driver/20220831-135855
        git checkout 8fab8b8c35fd4faebb003751d6d34fc06093c19e
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash drivers/gpio/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/gpio/gpio-latch.c: In function 'gpio_latch_probe':
>> drivers/gpio/gpio-latch.c:163:18: error: 'struct gpio_chip' has no member named 'of_node'; did you mean 'fwnode'?
     163 |         priv->gc.of_node = pdev->dev.of_node;
         |                  ^~~~~~~
         |                  fwnode


vim +163 drivers/gpio/gpio-latch.c

   123	
   124	static int gpio_latch_probe(struct platform_device *pdev)
   125	{
   126		struct gpio_latch_priv *priv;
   127	
   128		priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
   129		if (!priv)
   130			return -ENOMEM;
   131	
   132		priv->clk_gpios = devm_gpiod_get_array(&pdev->dev, "clk", GPIOD_OUT_LOW);
   133		if (IS_ERR(priv->clk_gpios))
   134			return PTR_ERR(priv->clk_gpios);
   135	
   136		priv->data_gpios = devm_gpiod_get_array(&pdev->dev, "data", GPIOD_OUT_LOW);
   137		if (IS_ERR(priv->data_gpios))
   138			return PTR_ERR(priv->data_gpios);
   139	
   140		priv->n_ports = priv->clk_gpios->ndescs;
   141		priv->n_pins = priv->data_gpios->ndescs;
   142	
   143		priv->shadow = devm_kcalloc(&pdev->dev, priv->n_ports, sizeof(*priv->shadow),
   144					    GFP_KERNEL);
   145		if (!priv->shadow)
   146			return -ENOMEM;
   147	
   148		if (gpio_latch_can_sleep(priv)) {
   149			priv->gc.can_sleep = true;
   150			priv->gc.set = gpio_latch_set_can_sleep;
   151			mutex_init(&priv->mutex);
   152		} else {
   153			priv->gc.can_sleep = false;
   154			priv->gc.set = gpio_latch_set;
   155			spin_lock_init(&priv->spinlock);
   156		}
   157	
   158		priv->gc.get_direction = gpio_latch_get_direction;
   159		priv->gc.ngpio = priv->n_ports * priv->n_pins;
   160		priv->gc.owner = THIS_MODULE;
   161		priv->gc.base = -1;
   162		priv->gc.parent = &pdev->dev;
 > 163		priv->gc.of_node = pdev->dev.of_node;
   164	
   165		platform_set_drvdata(pdev, priv);
   166	
   167		return devm_gpiochip_add_data(&pdev->dev, &priv->gc, priv);
   168	}
   169	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp