linux-kernel - Re: [PATCH net-next v4 7/9] net: marvell: prestera: add stub handler neighbour events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yw/PyBkjqaTSaxzM@yorlov.ow.s>
Date:   Thu, 1 Sep 2022 00:16:56 +0300
From:   Yevhen Orlov <yevhen.orlov@...ision.eu>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org,
        Volodymyr Mytnyk <volodymyr.mytnyk@...ision.eu>,
        Taras Chornyi <taras.chornyi@...ision.eu>,
        Mickey Rachamim <mickeyr@...vell.com>,
        Serhiy Pshyk <serhiy.pshyk@...ision.eu>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>,
        Stephen Hemminger <stephen@...workplumber.org>,
        linux-kernel@...r.kernel.org, Taras Chornyi <tchornyi@...vell.com>,
        Oleksandr Mazur <oleksandr.mazur@...ision.eu>
Subject: Re: [PATCH net-next v4 7/9] net: marvell: prestera: add stub handler
 neighbour events

Will recheck harder and update.
Thank you for review.

On Tue, Aug 30, 2022 at 03:11:00PM -0700, Jakub Kicinski wrote:
> On Thu, 25 Aug 2022 23:24:13 +0300 Yevhen Orlov wrote:
> > Actual handler will be added in next patches
> 
> Please make sure each point in the patch set builds cleanly.
> Here we have a warning which disappears with the next patch:
> 
> drivers/net/ethernet/marvell/prestera/prestera_router.c:624:26: warning: unused variable 'sw' [-Wunused-variable]
>         struct prestera_switch *sw = net_work->sw;
>                                 ^