linux-kernel - Re: [PATCH] libbpf: Initialize err in probe_map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1d5510f7-7c2d-6e30-f5d9-e45c470c380a@gmail.com>
Date:   Wed, 31 Aug 2022 14:50:51 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     patchwork-bot+netdevbpf@...nel.org
Cc:     bpf@...r.kernel.org, andrii@...nel.org, ast@...nel.org,
        daniel@...earbox.net, martin.lau@...ux.dev, song@...nel.org,
        yhs@...com, john.fastabend@...il.com, kpsingh@...nel.org,
        sdf@...gle.com, haoluo@...gle.com, jolsa@...nel.org,
        davemarchevsky@...com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] libbpf: Initialize err in probe_map_create



On 8/4/2022 2:50 PM, patchwork-bot+netdevbpf@...nel.org wrote:
> Hello:
> 
> This patch was applied to bpf/bpf-next.git (master)
> by Andrii Nakryiko <andrii@...nel.org>:
> 
> On Sun, 31 Jul 2022 19:51:09 -0700 you wrote:
>> GCC-11 warns about the possibly unitialized err variable in
>> probe_map_create:
>>
>> libbpf_probes.c: In function 'probe_map_create':
>> libbpf_probes.c:361:38: error: 'err' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>>    361 |                 return fd < 0 && err == exp_err ? 1 : 0;
>>        |                                  ~~~~^~~~~~~~~~
>>
>> [...]
> 
> Here is the summary with links:
>    - libbpf: Initialize err in probe_map_create
>      https://git.kernel.org/bpf/bpf-next/c/3045f42a6432
> 
> You are awesome, thank you!

Thanks for applying, I was sort of expecting this patch to land to Linus 
a bit quicker, as far as I can see it is still only in linux-next yet it 
does fix a build warning turned error. Any chance of fast tracking it?

Thanks!
-- 
Florian