linux-kernel - Re: [PATCH] RDMA/srp: Set scmnd->result only when scmnd is not NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5daac9db-2b34-fbe5-a891-8ecf77fbe46f@acm.org>
Date:   Tue, 30 Aug 2022 19:47:25 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     "yangx.jy@...itsu.com" <yangx.jy@...itsu.com>,
        "jgg@...dia.com" <jgg@...dia.com>,
        "leon@...nel.org" <leon@...nel.org>
Cc:     "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] RDMA/srp: Set scmnd->result only when scmnd is not NULL

On 8/30/22 18:47, yangx.jy@...itsu.com wrote:
> diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
> index 7720ea270ed8..528cdd0daba4 100644
> --- a/drivers/infiniband/ulp/srp/ib_srp.c
> +++ b/drivers/infiniband/ulp/srp/ib_srp.c
> @@ -1961,6 +1961,7 @@ static void srp_process_rsp(struct srp_rdma_ch *ch, struct srp_rsp *rsp)
>   		if (scmnd) {
>   			req = scsi_cmd_priv(scmnd);
>   			scmnd = srp_claim_req(ch, req, NULL, scmnd);
> +			scmnd->result = rsp->status;
>   		} else {
>   			shost_printk(KERN_ERR, target->scsi_host,
>   				     "Null scmnd for RSP w/tag %#016llx received on ch %td / QP %#x\n",
> @@ -1972,7 +1973,6 @@ static void srp_process_rsp(struct srp_rdma_ch *ch, struct srp_rsp *rsp)
>   
>   			return;
>   		}
> -		scmnd->result = rsp->status;
>   
>   		if (rsp->flags & SRP_RSP_FLAG_SNSVALID) {
>   			memcpy(scmnd->sense_buffer, rsp->data +

Since there is a 'return' statement in the else branch, I don't see how 
this patch can make a difference?

Thanks,

Bart.