linux-kernel - Re: [PATCH v1 5/9] crypto/ycc: Add skcipher algorithm support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <037A82F1-7C15-44E2-96B9-57CFEC936D38@linux.alibaba.com>
Date:   Wed, 31 Aug 2022 10:52:34 +0800
From:   guanjun <guanjun@...ux.alibaba.com>
To:     "Elliott, Robert (Servers)" <elliott@....com>
Cc:     "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "zelin.deng@...ux.alibaba.com" <zelin.deng@...ux.alibaba.com>,
        "xuchun.shang@...ux.alibaba.com" <xuchun.shang@...ux.alibaba.com>,
        "artie.ding@...ux.alibaba.com" <artie.ding@...ux.alibaba.com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 5/9] crypto/ycc: Add skcipher algorithm support

Hi Elliott,

> 2022年8月25日 上午12:24，Elliott, Robert (Servers) <elliott@....com> 写道：
> 
> 
> 
>> -----Original Message-----
>> From: 'Guanjun' <guanjun@...ux.alibaba.com>
>> Sent: Wednesday, August 24, 2022 4:50 AM
>> Subject: [PATCH v1 5/9] crypto/ycc: Add skcipher algorithm support
>> 
> ...
> 
>> +static struct skcipher_alg ycc_skciphers[] = {
>> +	{
>> +		.base = {
>> +			.cra_name = "cbc(aes)",
>> +			.cra_driver_name = "ycc_cbc(aes)",
> 
> In comparison, the aead driver puts the hardware driver name as a suffix,
> not a prefix, and uses dashes rather than underscores and parenthesis:
>> +			.cra_name = "gcm(aes)",
>> +			.cra_driver_name = "gcm-aes-ycc",
> 
> and the pk driver uses a prefix with a dash:
>> +		.cra_name = "rsa",
>> +		.cra_driver_name = "ycc-rsa",
> 
> Although the existing drivers are wildly inconsistent, it would be nice
> if this driver was at least consistent with itself. Suffixes with dashes
> seem to be the most popular, so consider these formats:
>  cbc-aes-ycc
>  gcm-aes-ycc
>  rsa-ycc
> 


Thanks for your comments. I will change these names as your suggestion in next version.

Best regards,
Guanjun