linux-kernel - Re: [PATCH v13 60/70] mm/msync: use vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 30 Aug 2022 19:55:14 -0700
From:   Davidlohr Bueso <dave@...olabs.net>
To:     Liam Howlett <liam.howlett@...cle.com>
Cc:     "maple-tree@...ts.infradead.org" <maple-tree@...ts.infradead.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Vlastimil Babka <vbabka@...e.cz>
Subject: Re: [PATCH v13 60/70] mm/msync: use vma_find() instead of vma linked
 list

On Mon, 22 Aug 2022, Liam Howlett wrote:

>From: "Liam R. Howlett" <Liam.Howlett@...cle.com>

-ENOCHANGELOG

>
>Signed-off-by: Liam R. Howlett <Liam.Howlett@...cle.com>
>Acked-by: Vlastimil Babka <vbabka@...e.cz>

... but looks good:

Reviewed-by: Davidlohr Bueso <dave@...olabs.net>

>---
> mm/msync.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mm/msync.c b/mm/msync.c
>index 137d1c104f3e..ac4c9bfea2e7 100644
>--- a/mm/msync.c
>+++ b/mm/msync.c
>@@ -104,7 +104,7 @@ SYSCALL_DEFINE3(msync, unsigned long, start, size_t, len, int, flags)
> 				error = 0;
> 				goto out_unlock;
> 			}
>-			vma = vma->vm_next;
>+			vma = find_vma(mm, vma->vm_end);
> 		}
> 	}
> out_unlock:
>
>-- 
>2.35.1
>