linux-kernel - Re: [PATCH] KVM: nVMX: Reword comments about generating nested CR0/4 read shadows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALMp9eToxFXZVz=8ZXWdrZAdQRn9V54g0VEaKDmmpqvPrYXQoA@mail.gmail.com>
Date:   Tue, 30 Aug 2022 17:28:50 -0700
From:   Jim Mattson <jmattson@...gle.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Jason Wang <wangborong@...rlc.com>
Subject: Re: [PATCH] KVM: nVMX: Reword comments about generating nested CR0/4
 read shadows

On Tue, Aug 30, 2022 at 5:07 PM Sean Christopherson <seanjc@...gle.com> wrote:
>
> Reword the comments that (attempt to) document nVMX's overrides of the
> CR0/4 read shadows for L2 after calling vmx_set_cr0/4().  The important
> behavior that needs to be documented is that KVM needs to override the
> shadows to account for L1's masks even though the shadows are set by the
> common helpers (and that setting the shadows first would result in the
> correct shadows being clobbered).
>
> This also fixes a repeated "we we" reported by Jason.
>
> Cc: Jason Wang <wangborong@...rlc.com>
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>
> ---
Reviewed-by: Jim Mattson <jmattson@...gle.com>