linux-kernel - Re: [PATCH v5 2/2] dts: arm: at91: Add SAMA5D3-EDS board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <daf497c5-4422-b8ce-1bbe-f2722962715c@linaro.org>
Date:   Wed, 31 Aug 2022 09:06:21 +0300
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Jerry.Ray@...rochip.com, robh+dt@...nel.org,
        Nicolas.Ferre@...rochip.com, alexandre.belloni@...tlin.com,
        Ludovic.Desroches@...rochip.com, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/2] dts: arm: at91: Add SAMA5D3-EDS board

On 30/08/2022 23:16, Jerry.Ray@...rochip.com wrote:
>>
>>> +
>>> +     chosen {
>>> +             stdout-path = "serial0:115200n8";
>>> +     };
>>> +
>>> +     clocks {
>>> +             slow_xtal {
>>
>> No underscores in node names. Generic node names, so at least add some generic prefix or suffix, e.g.: "slow-xtal-clock"
>>
> 
> I'm not at liberty to change these names.  Pre-existing drivers are counting on them.
> The hardware leverages the SAMA5D3-xplained board.
> I'm leveraging the at91-sama5d3_xplained.dts.
> The board will not boot up if I modify the names.

For custom names you have clock-output-names... But anyway it seems you
override existing nodes, so this should be override by label, not by
entire path.

Best regards,
Krzysztof