linux-kernel - Re: [PATCH v2 01/41] drm/tests: Order Kunit tests in Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220831073026.rjlqkznm6qf2yri5@houat>
Date:   Wed, 31 Aug 2022 09:30:26 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Konstantin Ryabitsev <konstantin@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 01/41] drm/tests: Order Kunit tests in Makefile

Hi,

On Tue, Aug 30, 2022 at 08:22:17AM -0400, Konstantin Ryabitsev wrote:
> (Dropping most cc's, who probably don't care about this thread.)
> 
> On Tue, Aug 30, 2022 at 10:30:27AM +0200, Maxime Ripard wrote:
> > > I noticed this, too, and I think the reason is because these patches were
> > > generated with "b4 send -o", but actually sent using git-send-email. It's not
> > > a use-case I've considered (or tested) and the breakage is because when b4
> > > generates patches with "-o", they are written with CRLF line endings, which is
> > > not something git-send-email expects.
> > 
> > You're right
> 
> OK, the latest master should allow you to do that without causing CRLF errors
> like this series.

Thanks

> > For some reason, b4 send doesn't work for my setup and I haven't had the
> > time to look into why and let you know.
> 
> Yeah, I see what the cause of it is:
> 
> > Connecting to /home/max/.local/bin/msmtpq:0
> > Failed to configure the smtp connection:
> > [Errno -2] Name or service not known
> 
> You have sendemail.smtpserver set to a path, which is supported by
> git-sendemail, but not by b4 (yet). I'll see if I can put that in today.

I saw that you fixed it in master, I'll give it a try, thanks!

Another thing I noticed when using b4 send is that I'm not sure how to
increment the version number of a series. With b4 send --dry-run it
wasn't happening automatically, and I couldn't find anything related in
the options (except for --force-revision but that wasn't permanent I
think?)

I ended up amending the commit json by hand to set the proper revision
number, but I'm almost sure it isn't the right way :)

Maxime