[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220831073622.5bp3ftf3fkea5rdk@pali>
Date: Wed, 31 Aug 2022 09:36:22 +0200
From: Pali Rohár <pali@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Michael Ellerman <mpe@...erman.id.au>,
devicetree@...r.kernel.org, linux-pm@...r.kernel.org,
linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
Marek Behún <kabel@...nel.org>
Subject: Re: [PATCH v2 1/3] dt-bindings: reset: syscon-reboot: Add priority
property
On Wednesday 31 August 2022 10:31:22 Krzysztof Kozlowski wrote:
> On 31/08/2022 02:00, Pali Rohár wrote:
> > This new optional priority property allows to specify custom priority level
> > of reset device. Default level was always 192.
>
> You still did not explain why do we need this. You only explained what
> you did here, which is obvious and visible from the diff. What you
> should explain is why you are doing it, what problem you are solving.
>
> Best regards,
> Krzysztof
Look at patch 3/3, thanks.
Powered by blists - more mailing lists