linux-kernel - Re: [PATCH] arch/riscv: kprobes: implement optprobes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d7729836-e50b-5ab6-464d-8bff87b54871@microchip.com>
Date:   Wed, 31 Aug 2022 07:51:31 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <chenguokai17@...ls.ucas.ac.cn>, <paul.walmsley@...ive.com>,
        <palmer@...belt.com>, <aou@...s.berkeley.edu>,
        <rostedt@...dmis.org>, <mingo@...hat.com>, <sfr@...b.auug.org.au>
CC:     <linux-riscv@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <liaochang1@...wei.com>
Subject: Re: [PATCH] arch/riscv: kprobes: implement optprobes

On 31/08/2022 08:24, Conor Dooley - M52691 wrote:
> Hey Chen,
> 
> FYI there is a build warning with this patch:
> arch/riscv/kernel/probes/opt.c:34:27: warning: no previous prototype for 'can_kprobe_direct_exec' [-Wmissing-prototypes]
>     34 | enum probe_insn __kprobes can_kprobe_direct_exec(kprobe_opcode_t *addr)
> 
> Also, if you run scripts/checkpatch.pl --strict, it will have a
> few complaints about code style for you too. Other than that, I
> have a few comments for you below:
> 
> On 31/08/2022 05:10, Chen Guokai wrote:

> [PATCH] arch/riscv: kprobes: implement optprobes

One more nitpick thing, could you make this either "riscv"
or "RISC-V" not "arch/riscv"?

Thanks :)