linux-kernel - RE: [PATCH V2 1/8] dt-bindings: soc: imx: add binding for i.MX9 syscon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DU0PR04MB94171C9075A78E962D7DD58888789@DU0PR04MB9417.eurprd04.prod.outlook.com>
Date:   Wed, 31 Aug 2022 07:57:56 +0000
From:   Peng Fan <peng.fan@....com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        "Peng Fan (OSS)" <peng.fan@....nxp.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>
CC:     "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>,
        Aisheng Dong <aisheng.dong@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH V2 1/8] dt-bindings: soc: imx: add binding for i.MX9
 syscon

Hi Krzysztof,

> Subject: Re: [PATCH V2 1/8] dt-bindings: soc: imx: add binding for i.MX9
> syscon
> 
> On 31/08/2022 10:49, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@....com>
> >
> > Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix
> >
> > Signed-off-by: Peng Fan <peng.fan@....com>
> > ---
> >  .../bindings/soc/imx/fsl,imx9-syscon.yaml     | 37 +++++++++++++++++++
> >  1 file changed, 37 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
> > b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
> > new file mode 100644
> > index 000000000000..90c5e354f86c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
> 
> Filename: fsl,imx93-syscon.yaml

There are more i.MX9 SoCs in the coming days, I am thinking to let this yaml
could cover i.MX9[X]. 
So should I use fsl,imx93-syscon.yaml for now, and rename to
fsl,imx9-syscon.yaml in future?

> 
> > @@ -0,0 +1,37 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> "https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevic
> etree.org%2Fschemas%2Fsoc%2Fimx%2Ffsl%2Cimx9-
> syscon.yaml%23&amp;data=05%7C01%7Cpeng.fan%40nxp.com%7C9dec9a
> aefa1e4c992bd708da8b259c6a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7
> C0%7C0%7C637975290892739302%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi
> MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C30
> 00%7C%7C%7C&amp;sdata=TvEdbjOMcDosQr5Q82t4aaO7KHJDn5YcSA%2B
> 9XDjj8%2Fc%3D&amp;reserved=0"
> > +$schema:
> "https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevic
> etree.org%2Fmeta-
> schemas%2Fcore.yaml%23&amp;data=05%7C01%7Cpeng.fan%40nxp.com%
> 7C9dec9aaefa1e4c992bd708da8b259c6a%7C686ea1d3bc2b4c6fa92cd99c5c3
> 01635%7C0%7C0%7C637975290892739302%7CUnknown%7CTWFpbGZsb3d
> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%
> 3D%7C3000%7C%7C%7C&amp;sdata=0G8y17uvPiZ22xChJCmlTWFX6Tl%2Fq
> G2kXF2bSUXDBaI%3D&amp;reserved=0"
> > +
> > +title: NXP i.MX9 Platforms System Controller bindings
> 
> s/bindings//
Drop "bindings" in V3.
> 
> > +
> > +maintainers:
> > +  - Peng Fan <peng.fan@....com>
> > +
> 
> Does not look like you tested the bindings. Please run `make
> dt_binding_check` (see Documentation/devicetree/bindings/writing-
> schema.rst for instructions).
> 
> You miss here select.

There is no error when I ran dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml 
 make ARCH=arm64 DT_CHECKER_FLAGS=-m dt_binding_check
  LINT    Documentation/devicetree/bindings
  CHKDT   Documentation/devicetree/bindings/processed-schema.json
  SCHEMA  Documentation/devicetree/bindings/processed-schema.json
  DTEX    Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.example.dts
  DTC     Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.example.dtb
  CHECK   Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.example.dtb
> 
> > +properties:
> > +  compatible:
> > +    oneOf:
> 
> Drop oneOf, unless you already have patch adding something more?

Ok, drop in v3.

Thanks,
Peng.

> 
> > +      - items:
> > +          - enum:
> > +              - fsl,imx93-aonmix-ns-syscfg
> > +              - fsl,imx93-wakeupmix-syscfg
> > +          - const: syscon
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> 
> 
> Best regards,
> Krzysztof