linux-kernel - Re: + mm-reduce-noise-in-show_mem-for-lowmem-allocations-update-fix.patch added to mm-unstable branch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Yw8Uq5rF19qVUQH+@dhcp22.suse.cz>
Date:   Wed, 31 Aug 2022 09:58:35 +0200
From:   Michal Hocko <mhocko@...e.com>
To:     linux-kernel@...r.kernel.org
Cc:     mm-commits@...r.kernel.org, vbabka@...e.cz, mgorman@...e.de,
        hch@...radead.org, hannes@...xchg.org, dan.carpenter@...cle.com,
        akpm@...ux-foundation.org
Subject: Re: +
 mm-reduce-noise-in-show_mem-for-lowmem-allocations-update-fix.patch added to
 mm-unstable branch

On Tue 30-08-22 19:57:43, Andrew Morton wrote:
> From: Andrew Morton <akpm@...ux-foundation.org>
> Subject: mm-reduce-noise-in-show_mem-for-lowmem-allocations-update-fix
> Date: Tue Aug 30 06:53:22 PM PDT 2022
> 
> fix build, remove unneeded __show_mem() arg
> 
> lib/show_mem.c: In function '__show_mem':
> lib/show_mem.c:17:9: error: too many arguments to function 'show_free_areas'
>    17 |         show_free_areas(filter, nodemask, max_zone_idx);
>       |         ^~~~~~~~~~~~~~~
> In file included from lib/show_mem.c:8:
> ./include/linux/mm.h:1842:28: note: declared here
>  1842 | static void __maybe_unused show_free_areas(unsigned int flags, nodemask_t *nodemask)
>       |                            ^~~~~~~~~~~~~~~
> 
> Cc: Christoph Hellwig <hch@...radead.org>
> Cc: Dan Carpenter <dan.carpenter@...cle.com>
> Cc: Johannes Weiner <hannes@...xchg.org>
> Cc: Mel Gorman <mgorman@...e.de>
> Cc: Michal Hocko <mhocko@...e.com>
> Cc: Vlastimil Babka <vbabka@...e.cz>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>

This should be addressed by
--- 
diff --git a/lib/show_mem.c b/lib/show_mem.c
index ade71096e241..0d7585cde2a6 100644
--- a/lib/show_mem.c
+++ b/lib/show_mem.c
@@ -14,7 +14,7 @@ void __show_mem(unsigned int filter, nodemask_t *nodemask, int max_zone_idx)
 	unsigned long total = 0, reserved = 0, highmem = 0;
 
 	printk("Mem-Info:\n");
-	show_free_areas(filter, nodemask, max_zone_idx);
+	__show_free_areas(filter, nodemask, max_zone_idx);
 
 	for_each_online_pgdat(pgdat) {
 		int zoneid;

-- 
Michal Hocko
SUSE Labs