linux-kernel - Re: [PATCH] sched/deadline: Add should_push_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a21358e0-c8b0-368c-5ebb-061598c0f3a6@huawei.com>
Date:   Wed, 31 Aug 2022 17:30:13 +0800
From:   shangxiaojing <shangxiaojing@...wei.com>
To:     Daniel Bristot de Oliveira <bristot@...hat.com>,
        <mingo@...hat.com>, <peterz@...radead.org>,
        <juri.lelli@...hat.com>, <vincent.guittot@...aro.org>,
        <dietmar.eggemann@....com>, <rostedt@...dmis.org>,
        <bsegall@...gle.com>, <mgorman@...e.de>, <vschneid@...hat.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched/deadline: Add should_push_task_away helper


On 2022/8/31 17:23, Daniel Bristot de Oliveira wrote:
> On 8/29/22 12:05, Shang XiaoJing wrote:
>> +static inline bool should_push_task_away(struct task_struct *a,
>> +					  struct task_struct *b)
> static inline bool should_push_task_dl(struct task_struct *curr, struct task_struct *p)
>
> a and b are not good variable names, and add the _dl suffix (instead of away).
ok, i like that :-). This will be done in patch v2.
>> +{
>> +	return unlikely(dl_task(a)) &&
>> +	       (a->nr_cpus_allowed < 2 ||
>> +		!dl_entity_preempt(&b->dl, &a->dl)) &&
>> +	       b->nr_cpus_allowed > 1;
>> +}
>> +
> -- Daniel

Thanks,

Shang XiaoJing