linux-kernel - Re: [PATCH 01/15] cxl/core: Remove duplicate declaration of devm_cxl_iomap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 31 Aug 2022 17:39:09 +0800
From:   kernel test robot <lkp@...el.com>
To:     Robert Richter <rrichter@....com>,
        Alison Schofield <alison.schofield@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Ira Weiny <ira.weiny@...el.com>,
        Ben Widawsky <bwidawsk@...nel.org>,
        Dan Williams <dan.j.williams@...el.com>
Cc:     kbuild-all@...ts.01.org, linux-cxl@...r.kernel.org,
        linux-kernel@...r.kernel.org, Bjorn Helgaas <helgaas@...nel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>, Robert Richter <rrichter@....com>
Subject: Re: [PATCH 01/15] cxl/core: Remove duplicate declaration of
 devm_cxl_iomap_block()

Hi Robert,

I love your patch! Perhaps something to improve:

[auto build test WARNING on helgaas-pci/next]
[also build test WARNING on linus/master v6.0-rc3 next-20220830]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Robert-Richter/cxl-Add-support-for-Restricted-CXL-hosts-RCD-mode/20220831-161955
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: alpha-allyesconfig
compiler: alpha-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/cb2fb876ae88418bdae58f974a4905b661792cc5
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Robert-Richter/cxl-Add-support-for-Restricted-CXL-hosts-RCD-mode/20220831-161955
        git checkout cb2fb876ae88418bdae58f974a4905b661792cc5
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash drivers/cxl/core/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/cxl/core/regs.c:162:15: warning: no previous prototype for 'devm_cxl_iomap_block' [-Wmissing-prototypes]
     162 | void __iomem *devm_cxl_iomap_block(struct device *dev, resource_size_t addr,
         |               ^~~~~~~~~~~~~~~~~~~~


vim +/devm_cxl_iomap_block +162 drivers/cxl/core/regs.c

0f06157e0135f5 Dan Williams 2021-08-03  161  
d17d0540a0dbf1 Dan Williams 2022-02-01 @162  void __iomem *devm_cxl_iomap_block(struct device *dev, resource_size_t addr,
0f06157e0135f5 Dan Williams 2021-08-03  163  				   resource_size_t length)
0f06157e0135f5 Dan Williams 2021-08-03  164  {
0f06157e0135f5 Dan Williams 2021-08-03  165  	void __iomem *ret_val;
0f06157e0135f5 Dan Williams 2021-08-03  166  	struct resource *res;
0f06157e0135f5 Dan Williams 2021-08-03  167  
0f06157e0135f5 Dan Williams 2021-08-03  168  	res = devm_request_mem_region(dev, addr, length, dev_name(dev));
0f06157e0135f5 Dan Williams 2021-08-03  169  	if (!res) {
0f06157e0135f5 Dan Williams 2021-08-03  170  		resource_size_t end = addr + length - 1;
0f06157e0135f5 Dan Williams 2021-08-03  171  
0f06157e0135f5 Dan Williams 2021-08-03  172  		dev_err(dev, "Failed to request region %pa-%pa\n", &addr, &end);
0f06157e0135f5 Dan Williams 2021-08-03  173  		return NULL;
0f06157e0135f5 Dan Williams 2021-08-03  174  	}
0f06157e0135f5 Dan Williams 2021-08-03  175  
0f06157e0135f5 Dan Williams 2021-08-03  176  	ret_val = devm_ioremap(dev, addr, length);
0f06157e0135f5 Dan Williams 2021-08-03  177  	if (!ret_val)
0f06157e0135f5 Dan Williams 2021-08-03  178  		dev_err(dev, "Failed to map region %pr\n", res);
0f06157e0135f5 Dan Williams 2021-08-03  179  
0f06157e0135f5 Dan Williams 2021-08-03  180  	return ret_val;
0f06157e0135f5 Dan Williams 2021-08-03  181  }
0f06157e0135f5 Dan Williams 2021-08-03  182  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (310973 bytes)