linux-kernel - Re: [PATCH next v2 2/2] dt-bindings: i2c: add entry for hisilicon,hisi-i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ffa076ea-2675-05ab-00bb-30b77ef13cba@huawei.com>
Date:   Wed, 31 Aug 2022 17:53:51 +0800
From:   Yicong Yang <yangyicong@...wei.com>
To:     Weilong Chen <chenweilong@...wei.com>, <yangyicong@...ilicon.com>,
        <wsa@...nel.org>
CC:     <linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <xuwei5@...wei.com>
Subject: Re: [PATCH next v2 2/2] dt-bindings: i2c: add entry for
 hisilicon,hisi-i2c

[+cc xuwei for device tree expertise]

On 2022/8/25 17:24, Weilong Chen wrote:
> Add the new compatible for hisi common i2c.
> 

s/hisi/HiSilicon

> Signed-off-by: Weilong Chen <chenweilong@...wei.com>
> ---
>  .../bindings/i2c/hisilicon,hisi-i2c.yaml      | 50 +++++++++++++++++++
>  1 file changed, 50 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/i2c/hisilicon,hisi-i2c.yaml
> 
> diff --git a/Documentation/devicetree/bindings/i2c/hisilicon,hisi-i2c.yaml b/Documentation/devicetree/bindings/i2c/hisilicon,hisi-i2c.yaml
> new file mode 100644
> index 000000000000..ea967abfe144
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/i2c/hisilicon,hisi-i2c.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/i2c/hisilicon,hisi-i2c.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Hisilicon common IIC controller Device Tree Bindings
> +

It's ok to have "HiSilicon common IIC controller"

> +maintainers:
> +  - yangyicong@...wei.com
> +
> +allOf:
> +  - $ref: /schemas/i2c/i2c-controller.yaml#
> +
> +properties:
> +  compatible:
> +    const: hisilicon,hisi-i2c
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clk_rate:
> +    maxItems: 1
> +
> +  clock-frequency:
> +    default: 100000
> +

I think it misses some properties here?

- i2c-sda-hold-time-ns
- sda_fall_ns
- scl_rise_ns
...

Do we need to mention them here?

Thanks.

> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clk_rate
> +  - clock-frequency
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    i2c1: i2c@...8B0000{
> +      compatible = "hisilicon,hisi-i2c";
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      reg = <0x5 0x038B0000 0 0x10000>;
> +      interrupts = <0x0 120 0x4>;
> +      clk_rate = <0x0 0xEE6B280>;
> +      clock-frequency = <400000>;
> +    };
>