linux-kernel - Re: [PATCH 1/2] drm/tests: Split drm_framebuffer_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220831104941.doc75juindcm5mcl@nostramo.hardline.pl>
Date:   Wed, 31 Aug 2022 12:49:41 +0200
From:   Michał Winiarski <michal.winiarski@...el.com>
To:     Maíra Canal <mairacanal@...eup.net>
CC:     Isabella Basso <isabbasso@...eup.net>, <magalilemes00@...il.com>,
        <tales.aparecida@...il.com>, <mwen@...lia.com>,
        <andrealmeid@...eup.net>, <siqueirajordao@...eup.net>,
        Trevor Woerner <twoerner@...il.com>,
        "Daniel Vetter" <daniel@...ll.ch>, David Airlie <airlied@...ux.ie>,
        "Javier Martinez Canillas" <javierm@...hat.com>,
        David Gow <davidgow@...gle.com>, <brendanhiggins@...gle.com>,
        Arthur Grillo <arthur.grillo@....br>,
        José Expósito <jose.exposito89@...il.com>,
        <kunit-dev@...glegroups.com>, <linux-kselftest@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] drm/tests: Split drm_framebuffer_create_test into
 parameterized tests

On Tue, Aug 30, 2022 at 06:16:02PM -0300, Maíra Canal wrote:
> The igt_check_drm_framebuffer_create is based on a loop that executes
> tests for all createbuffer_tests test cases. This could be better
> represented by parameterized tests, provided by KUnit.
> 
> So, convert the igt_check_drm_framebuffer_create test into parameterized tests.
> 
> Signed-off-by: Maíra Canal <mairacanal@...eup.net>

Now that we have separate testcases, we may also want to consider using .init
for mock_drm_device instead of a global
(see:
https://lore.kernel.org/dri-devel/20220117232259.180459-5-michal.winiarski@intel.com/
for reference)

Either way:
Reviewed-by: Michał Winiarski <michal.winiarski@...el.com>

-Michał

> ---
>  drivers/gpu/drm/tests/drm_framebuffer_test.c | 23 +++++++++-----------
>  1 file changed, 10 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b/drivers/gpu/drm/tests/drm_framebuffer_test.c
> index ec7a08ba4056..3e46fd9f6615 100644
> --- a/drivers/gpu/drm/tests/drm_framebuffer_test.c
> +++ b/drivers/gpu/drm/tests/drm_framebuffer_test.c
> @@ -25,7 +25,7 @@ struct drm_framebuffer_test {
>  	const char *name;
>  };