linux-kernel - 回复: [PATCH V1 1/1] mmc:sdhci:Fix the SD tuning CMD parameter issue that the SDHCI_TRANSFER_MODE is cleared from read direction to write direction incorrectly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR16MB4248A089CB5FF2BEC527742FEA789@PH0PR16MB4248.namprd16.prod.outlook.com>
Date:   Wed, 31 Aug 2022 12:04:49 +0000
From:   "Chevron Li (WH)" <chevron.li@...hubtech.com>
To:     Adrian Hunter <adrian.hunter@...el.com>,
        "Charl Liu (WH)" <charl.liu@...hubtech.com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "Shaper Liu (WH)" <shaper.liu@...hubtech.com>,
        "Thomas Hu(WH)" <thomas.hu@...hubtech.com>,
        "XiaoGuang Yu (WH)" <xiaoguang.yu@...hubtech.com>,
        "Shirley Her(SC)" <shirley.her@...hubtech.com>
Subject: 回复: [PATCH V1 1/1] mmc:sdhci:Fix the SD tuning CMD parameter issue that the SDHCI_TRANSFER_MODE is cleared from read direction to write direction incorrectly

Hi, Adrian,

Sorry response you so late.

Does your comment "mmc_op_tuning() could be used here" means that we should use mmc_send_tuning() instead of sdhci_send_tuning?

If yes, I think we need add below patch commit by Charl Liu for those reasons:
1.Bayhub host tuning command does not have a data payload and our hardware does it automatically, so mmc_send_tuning() will return -EIO.
2.Bayhub host can be used for both SD and eMMC cards.
3.Both MMC_SEND_TUNING_BLOCK and MMC_SEND_TUNING_BLOCK_HS200 are tuning command opcode, maybe the same logical at here is better? 

BR,
Chevron

-----邮件原件-----
发件人: Adrian Hunter <adrian.hunter@...el.com> 
发送时间: Sunday, July 24, 2022 15:22
收件人: Charl Liu (WH) <charl.liu@...hubtech.com>; ulf.hansson@...aro.org; linux-mmc@...r.kernel.org; linux-kernel@...r.kernel.org
抄送: Shaper Liu (WH) <shaper.liu@...hubtech.com>; Chevron Li (WH) <chevron.li@...hubtech.com>; Thomas Hu(WH) <thomas.hu@...hubtech.com>; XiaoGuang Yu (WH) <xiaoguang.yu@...hubtech.com>; Shirley Her(SC) <shirley.her@...hubtech.com>
主题: Re: [PATCH V1 1/1] mmc:sdhci:Fix the SD tuning CMD parameter issue that the SDHCI_TRANSFER_MODE is cleared from read direction to write direction incorrectly

On 20/07/22 15:37, Charl Liu wrote:
> When cmd->opcode == MMC_SEND_TUNING_BLOCK, the SDHCI_TRANSFER_MODE 
> should also be kept
> 
> Signed-off-by: Charl Liu <charl.liu@...hubtech.com>
> ---
> Change in V1:
> Keeping the SDHCI_TRANSFER_MODE when cmd->opcode == MMC_END_TUNING_ 
> BLOCK
> ---
>  drivers/mmc/host/sdhci.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 
> 22152029e14c..6a0f6725dadb 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -1430,7 +1430,8 @@ static void sdhci_set_transfer_mode(struct sdhci_host *host,
>  		if (host->quirks2 &
>  			SDHCI_QUIRK2_CLEAR_TRANSFERMODE_REG_BEFORE_CMD) {
>  			/* must not clear SDHCI_TRANSFER_MODE when tuning */
> -			if (cmd->opcode != MMC_SEND_TUNING_BLOCK_HS200)
> +			if ((cmd->opcode != MMC_SEND_TUNING_BLOCK_HS200) &&
> +			(cmd->opcode != MMC_SEND_TUNING_BLOCK))

mmc_op_tuning() could be used here

>  				sdhci_writew(host, 0x0, SDHCI_TRANSFER_MODE);
>  		} else {
>  		/* clear Auto CMD settings for no data CMDs */