linux-kernel - Re: [PATCH v2 3/3] iio: adc: tsc2046: silent spi_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcO=ipD8nW8CdQ18u1-SaD8GU1W=dUihCu+GqQrq3Uwcg@mail.gmail.com>
Date:   Wed, 31 Aug 2022 15:33:06 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] iio: adc: tsc2046: silent spi_device_id warning

On Wed, Aug 31, 2022 at 1:01 PM Oleksij Rempel <o.rempel@...gutronix.de> wrote:

All below are minors (but you really need to Cc reviewers from the
previous round(s) to pay the respect), so I leave them to IIO
maintainers.

...

> Add spi_device_id to silent following kernel runtime warning:
> "SPI driver tsc2046 has no spi_device_id for ti,tsc2046e-adc"

Missed period.

>         dcfg = device_get_match_data(dev);
> +       if (!dcfg) {

> +               const struct spi_device_id *id;
> +
> +               id = spi_get_device_id(spi);

You can move assignment to the definition line.

> +               dcfg = (const struct tsc2046_adc_dcfg *)id->driver_data;
> +       }

> +

Unneeded blank line, since these all are grouped semantically.

>         if (!dcfg)
>                 return -EINVAL;

-- 
With Best Regards,
Andy Shevchenko