linux-kernel - Re: [PATCH V2 1/8] dt-bindings: soc: imx: add binding for i.MX9 syscon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4c060e3d-5a2c-2073-099d-1dcd649e469e@oss.nxp.com>
Date:   Wed, 31 Aug 2022 21:59:20 +0800
From:   Peng Fan <peng.fan@....nxp.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        shawnguo@...nel.org, s.hauer@...gutronix.de
Cc:     kernel@...gutronix.de, festevam@...il.com, linux-imx@....com,
        aisheng.dong@....com, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Peng Fan <peng.fan@....com>
Subject: Re: [PATCH V2 1/8] dt-bindings: soc: imx: add binding for i.MX9
 syscon



On 8/31/2022 9:45 PM, Krzysztof Kozlowski wrote:
> On 31/08/2022 16:41, Peng Fan wrote:
>>
>>
>> On 8/31/2022 8:54 PM, Krzysztof Kozlowski wrote:
>>> On 31/08/2022 13:08, Peng Fan wrote:
>>>>
>>>>
>>>> On 8/31/2022 5:15 PM, Krzysztof Kozlowski wrote:
>>>>> On 31/08/2022 10:49, Peng Fan (OSS) wrote:
>>>>>> From: Peng Fan <peng.fan@....com>
>>>>>>
>>>>>> Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix
>>>>>>
>>>>>> Signed-off-by: Peng Fan <peng.fan@....com>
>>>>>> ---
>>>>>>     .../bindings/soc/imx/fsl,imx9-syscon.yaml     | 37 +++++++++++++++++++
>>>>>>     1 file changed, 37 insertions(+)
>>>>>>     create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>>>>>>
>>>>>> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>>>>>> new file mode 100644
>>>>>> index 000000000000..90c5e354f86c
>>>>>> --- /dev/null
>>>>>> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>>>>>> @@ -0,0 +1,37 @@
>>>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>>>>> +%YAML 1.2
>>>>>> +---
>>>>>> +$id: "http://devicetree.org/schemas/soc/imx/fsl,imx9-syscon.yaml#"
>>>>>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>>>>>
>>>>> One more - drop the quotes both lines above.
>>>>
>>>> There will be dtbs_check error. I updated schema with:
>>>> pip3 install git+https://github.com/devicetree-org/dt-schema.git@main
>>>>
>>>> So it is ok the drop the two quotes above? Is there
>>>> any new update in dt-schema that not landed in repo?
>>>
>>> This is something new to me, can you paste the error?
>>
>> I have renamed the file to "fsl,imx93-syscon.yaml"
>>
>> $DT_SCHEMA_FILES=Documentation/devicetree/bindings/soc/imx/fsl,imx93-syscon.yaml
>> make ARCH=arm64 DT_CHECKER_FLAGS=-m dtbs_check
>>
>>     LINT    Documentation/devicetree/bindings
>>     CHKDT   Documentation/devicetree/bindings/processed-schema.json
>> ./Documentation/devicetree/bindings/soc/imx/fsl,imx93-syscon.yaml: error
>> checking schema file
>>     SCHEMA  Documentation/devicetree/bindings/processed-schema.json
> 
> Hm, not much of an actual message. Most - or almost all - bindings do
> not have quotes, you know...
> 
> This is something with your setup because above error is not reproducible.

I got something wrong in my side, my bad. It passes check now.

Thanks,
Peng.

> 
> Best regards,
> Krzysztof