linux-kernel - Re: [PATCH] scsi: megaraid: convert sysfs snprintf to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a4a486b3-7acc-090f-d9c5-bac7a2239482@opensource.wdc.com>
Date:   Thu, 1 Sep 2022 09:24:48 +0900
From:   Damien Le Moal <damien.lemoal@...nsource.wdc.com>
To:     Xuezhi Zhang <zhangxuezhi3@...il.com>, kashyap.desai@...adcom.com,
        sumit.saxena@...adcom.com, shivasharan.srikanteshwara@...adcom.com,
        jejb@...ux.ibm.com, martin.petersen@...cle.com
Cc:     megaraidlinux.pdl@...adcom.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Xuezhi Zhang <zhangxuezhi1@...lpad.com>
Subject: Re: [PATCH] scsi: megaraid: convert sysfs snprintf to sysfs_emit

On 8/31/22 23:03, Xuezhi Zhang wrote:
> From: Xuezhi Zhang <zhangxuezhi1@...lpad.com>
> 
> Fix up all sysfs show entries to use sysfs_emit
> 
> Signed-off-by: Xuezhi Zhang <zhangxuezhi1@...lpad.com>

Looks OK.

Reviewed-by: Damien Le Moal <damien.lemoal@...nsource.wdc.com>

> ---
>  drivers/scsi/megaraid/megaraid_mbox.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/megaraid/megaraid_mbox.c b/drivers/scsi/megaraid/megaraid_mbox.c
> index 157c3bdb50be..132de68c14e9 100644
> --- a/drivers/scsi/megaraid/megaraid_mbox.c
> +++ b/drivers/scsi/megaraid/megaraid_mbox.c
> @@ -3979,7 +3979,7 @@ megaraid_mbox_app_hndl_show(struct device *dev, struct device_attribute *attr, c
>  
>  	app_hndl = mraid_mm_adapter_app_handle(adapter->unique_id);
>  
> -	return snprintf(buf, 8, "%u\n", app_hndl);
> +	return sysfs_emit(buf, "%u\n", app_hndl);
>  }
>  
>  
> @@ -4048,7 +4048,7 @@ megaraid_mbox_ld_show(struct device *dev, struct device_attribute *attr, char *b
>  		}
>  	}
>  
> -	return snprintf(buf, 36, "%d %d %d %d\n", scsi_id, logical_drv,
> +	return sysfs_emit(buf, "%d %d %d %d\n", scsi_id, logical_drv,
>  			ldid_map, app_hndl);
>  }
>  

-- 
Damien Le Moal
Western Digital Research