linux-kernel - Re: [PATCH v2] drm/amd/display: fix indentation in commit_planes_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <417bdb98-e22b-5316-7f71-5797ac001a53@amd.com>
Date:   Thu, 1 Sep 2022 11:47:17 -0400
From:   Rodrigo Siqueira Jordao <Rodrigo.Siqueira@....com>
To:     Hamza Mahfooz <hamza.mahfooz@....com>, linux-kernel@...r.kernel.org
Cc:     Harry Wentland <harry.wentland@....com>,
        Leo Li <sunpeng.li@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Nicholas Kazlauskas <nicholas.kazlauskas@....com>,
        Jun Lei <Jun.Lei@....com>,
        Meenakshikumar Somasundaram <meenakshikumar.somasundaram@....com>,
        Alvin Lee <Alvin.Lee2@....com>,
        Martin Leung <martin.leung@....com>,
        Samson Tam <Samson.Tam@....com>, Alex Hung <alex.hung@....com>,
        Wenjing Liu <wenjing.liu@....com>,
        Joshua Aberback <joshua.aberback@....com>,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2] drm/amd/display: fix indentation in
 commit_planes_for_stream()



On 2022-09-01 10:15, Hamza Mahfooz wrote:
> Address the following warning:
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3508:9: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
>   3508 |         if (update_type != UPDATE_TYPE_FAST)
>        |         ^~
> drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3510:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
>   3510 |                 if (update_type != UPDATE_TYPE_FAST)
>        |                 ^~
> 
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@....com>
> ---
> v2: implement feedback from Alvin
> ---
>   drivers/gpu/drm/amd/display/dc/core/dc.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index b49237390cce..9860bf38c547 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -3507,9 +3507,10 @@ static void commit_planes_for_stream(struct dc *dc,
>   
>   	if (update_type != UPDATE_TYPE_FAST)
>   		dc->hwss.post_unlock_program_front_end(dc, context);
> -		if (update_type != UPDATE_TYPE_FAST)
> -			if (dc->hwss.commit_subvp_config)
> -				dc->hwss.commit_subvp_config(dc, context);
> +
> +	if (update_type != UPDATE_TYPE_FAST)
> +		if (dc->hwss.commit_subvp_config)
> +			dc->hwss.commit_subvp_config(dc, context);
>   
>   	/* Since phantom pipe programming is moved to post_unlock_program_front_end,
>   	 * move the SubVP lock to after the phantom pipes have been setup

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@....com>
and applied to amd-staging-drm-next.

Thanks
Siqueira