linux-kernel - Re: [PATCH -next] xfs: missing space in xfs trace log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YxDZUyN1XgawXvqD@magnolia>
Date:   Thu, 1 Sep 2022 09:09:55 -0700
From:   "Darrick J. Wong" <djwong@...nel.org>
To:     Zeng Heng <zengheng4@...wei.com>
Cc:     linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] xfs: missing space in xfs trace log

On Thu, Sep 01, 2022 at 07:02:05PM +0800, Zeng Heng wrote:
> Add space between arguments would help someone
> to locate the key words they want, so break
> quoted strings at a space character.
> 
> Such as below:
> [Before]
> kworker/1:0-280     [001] .....   600.782135: xfs_bunmap:
> dev 7:0 ino 0x85 disize 0x0 fileoff 0x0 fsbcount 0x400000001fffffflags ATTRFORK ...
> 
> [After]
> kworker/1:2-564     [001] ..... 23817.906160: xfs_bunmap:
> dev 7:0 ino 0x85 disize 0x0 fileoff 0x0 fsbcount 0x400000001fffff flags ATTRFORK ...
> 
> Signed-off-by: Zeng Heng <zengheng4@...wei.com>

Whoops, thanks for cleaning this up.
Reviewed-by: Darrick J. Wong <djwong@...nel.org>

--D

> ---
>  fs/xfs/xfs_trace.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h
> index f9057af6e0c8..cb7c81ba7fa3 100644
> --- a/fs/xfs/xfs_trace.h
> +++ b/fs/xfs/xfs_trace.h
> @@ -1170,7 +1170,7 @@ DECLARE_EVENT_CLASS(xfs_dqtrx_class,
>  		__entry->ino_res_used = qtrx->qt_ino_res_used;
>  		__entry->icount_delta = qtrx->qt_icount_delta;
>  	),
> -	TP_printk("dev %d:%d dquot id 0x%x type %s flags %s"
> +	TP_printk("dev %d:%d dquot id 0x%x type %s flags %s "
>  		  "blk_res %llu bcount_delta %lld delbcnt_delta %lld "
>  		  "rtblk_res %llu rtblk_res_used %llu rtbcount_delta %lld delrtb_delta %lld "
>  		  "ino_res %llu ino_res_used %llu icount_delta %lld",
> @@ -1602,7 +1602,7 @@ TRACE_EVENT(xfs_bunmap,
>  		__entry->caller_ip = caller_ip;
>  		__entry->flags = flags;
>  	),
> -	TP_printk("dev %d:%d ino 0x%llx disize 0x%llx fileoff 0x%llx fsbcount 0x%llx"
> +	TP_printk("dev %d:%d ino 0x%llx disize 0x%llx fileoff 0x%llx fsbcount 0x%llx "
>  		  "flags %s caller %pS",
>  		  MAJOR(__entry->dev), MINOR(__entry->dev),
>  		  __entry->ino,
> -- 
> 2.25.1
>