linux-kernel - Re: [PATCH v2 3/8] termios: uninline conversion helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YxDlyBneTC/zBx4S@ZenIV>
Date:   Thu, 1 Sep 2022 18:03:04 +0100
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-arch@...r.kernel.org,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/8] termios: uninline conversion helpers

On Tue, Aug 30, 2022 at 02:26:16PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Aug 21, 2022 at 02:02:34AM +0100, Al Viro wrote:
> > default go into drivers/tty/tty_ioctl.c, unusual - into
> > arch/*/kernel/termios.c (only alpha and sparc have those).
> > 
> > Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
> > ---
> >  arch/alpha/include/asm/termios.h   |  77 ++--------------
> >  arch/alpha/kernel/Makefile         |   2 +-
> >  arch/alpha/kernel/termios.c        |  57 ++++++++++++
> >  arch/ia64/include/asm/termios.h    |  41 ++-------
> >  arch/mips/include/asm/termios.h    |  84 ++----------------
> >  arch/parisc/include/asm/termios.h  |  41 ++-------
> >  arch/sparc/include/asm/termios.h   | 136 ++---------------------------
> >  arch/sparc/kernel/Makefile         |   4 +-
> >  arch/sparc/kernel/termios.c        | 115 ++++++++++++++++++++++++
> >  drivers/tty/tty_ioctl.c            |  74 ++++++++++++++++
> >  include/asm-generic/termios-base.h |  69 ++-------------
> >  include/asm-generic/termios.h      |  42 ++-------
> >  12 files changed, 294 insertions(+), 448 deletions(-)
> >  create mode 100644 arch/alpha/kernel/termios.c
> >  create mode 100644 arch/sparc/kernel/termios.c
> 
> The build blows up on me with this commit added to my tty-testing tree:

My apologies - reordering damage.  inlines in include/asm-generic/termios.h
should've been removed in this commit, not in the next one.

Anyway, fixed branch rebased on top of your #tty-next; see
vfs.git #work.termios2.  Individual patches in followups...