linux-kernel - Re: [PATCH v2 04/19] Partially revert "KVM: Pass kvm_init()'s opaque param to additional arch funcs"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220901180137.GI2711697@ls.amr.corp.intel.com>
Date:   Thu, 1 Sep 2022 11:01:37 -0700
From:   Isaku Yamahata <isaku.yamahata@...il.com>
To:     "Huang, Kai" <kai.huang@...el.com>
Cc:     "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Yamahata, Isaku" <isaku.yamahata@...el.com>,
        "Gao, Chao" <chao.gao@...el.com>,
        "Christopherson,, Sean" <seanjc@...gle.com>,
        "suzuki.poulose@....com" <suzuki.poulose@....com>,
        "isaku.yamahata@...il.com" <isaku.yamahata@...il.com>,
        "will@...nel.org" <will@...nel.org>,
        "anup@...infault.org" <anup@...infault.org>,
        "pbonzini@...hat.com" <pbonzini@...hat.com>,
        "imbrenda@...ux.ibm.com" <imbrenda@...ux.ibm.com>
Subject: Re: [PATCH v2 04/19] Partially revert "KVM: Pass kvm_init()'s opaque
 param to additional arch funcs"

On Tue, Aug 30, 2022 at 10:39:48PM +0000,
"Huang, Kai" <kai.huang@...el.com> wrote:

> On Tue, 2022-08-30 at 05:01 -0700, isaku.yamahata@...el.com wrote:
> > From: Chao Gao <chao.gao@...el.com>
> > 
> > This partially reverts commit b99040853738 ("KVM: Pass kvm_init()'s opaque
> > param to additional arch funcs") remove opaque from
> > kvm_arch_check_processor_compat because no one uses this opaque now.
> > Address conflicts for ARM (due to file movement) and manually handle RISC-V
> > which comes after the commit.  The change about kvm_arch_hardware_setup()
> > in original commit are still needed so they are not reverted.
> > 
> > The current implementation enables hardware (e.g. enable VMX on all CPUs),
> > arch-specific initialization for the first VM creation, and disables
> > hardware (in x86, disable VMX on all CPUs) for last VM destruction.
> > 
> > To support TDX, hardware_enable_all() will be done during module loading
> > time.  As a result, CPU compatibility check will be opportunistically moved
> > to hardware_enable_nolock(), which doesn't take any argument.  Instead of
> > passing 'opaque' around to hardware_enable_nolock() and
> > hardware_enable_all(), just remove the unused 'opaque' argument from
> > kvm_arch_check_processor_compat().
> 
> This patch now is not part of TDX's series, so it doesn't make a lot sense to
> put the last two paragraphs here (because the purpose is different).  I think
> you can just use Chao's original patch.

Ok.
-- 
Isaku Yamahata <isaku.yamahata@...il.com>