linux-kernel - Re: [PATCH 1/9] trinity: Add base driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YxD7kWBl88kMbdi5@sirena.org.uk>
Date:   Thu, 1 Sep 2022 19:36:01 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Jiho Chu <jiho.chu@...sung.com>
Cc:     gregkh@...uxfoundation.org, arnd@...db.de,
        linux-kernel@...r.kernel.org, yelini.jeong@...sung.com,
        myungjoo.ham@...sung.com
Subject: Re: [PATCH 1/9] trinity: Add base driver

On Mon, Jul 25, 2022 at 03:53:00PM +0900, Jiho Chu wrote:

> +	drv->opened = drv->opened - 1;
> +	if (drv->opened == 0) {
> +		/* wait already submitted requests */
> +		if (drv->desc->drain_reqs)
> +			drv->desc->drain_reqs(drv);

> +		drv->desc->set_state(drv, TRINITY_STATE_PAUSE);

> +	mutex_lock(&drv->lock);
> +	/** remove PAUSE set on the CP of the NPU */
> +	if (drv->opened == 0) {
> +		ret = trinity_wait_ready(drv);
> +		if (ret != 0)
> +			goto out;
> +	}
> +	drv->opened = drv->opened + 1;

Would it perhaps be cleaner to hold a runtime PM reference on the
device for each file and deal with the power up/down of the hardware in
the runtime PM callbacks?

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)