[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAJuCfpFqK+Gfd100C8s8jnJci+UCt9y6dqsn=eqYin6g-VVx6Q@mail.gmail.com>
Date: Thu, 1 Sep 2022 16:18:04 -0700
From: Suren Baghdasaryan <surenb@...gle.com>
To: Kent Overstreet <kent.overstreet@...ux.dev>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Michel Lespinasse <michel@...pinasse.org>,
Jerome Glisse <jglisse@...gle.com>,
Michal Hocko <mhocko@...e.com>,
Vlastimil Babka <vbabka@...e.cz>,
Johannes Weiner <hannes@...xchg.org>,
Mel Gorman <mgorman@...e.de>,
Davidlohr Bueso <dave@...olabs.net>,
Matthew Wilcox <willy@...radead.org>,
"Liam R. Howlett" <liam.howlett@...cle.com>,
Peter Zijlstra <peterz@...radead.org>,
Laurent Dufour <ldufour@...ux.ibm.com>,
Laurent Dufour <laurent.dufour@...ibm.com>,
"Paul E . McKenney" <paulmck@...nel.org>,
Andy Lutomirski <luto@...nel.org>,
Song Liu <songliubraving@...com>, Peter Xu <peterx@...hat.com>,
David Hildenbrand <david@...hat.com>, dhowells@...hat.com,
Hugh Dickins <hughd@...gle.com>, bigeasy@...utronix.de,
David Rientjes <rientjes@...gle.com>,
Axel Rasmussen <axelrasmussen@...gle.com>,
Joel Fernandes <joelaf@...gle.com>,
Minchan Kim <minchan@...gle.com>,
kernel-team <kernel-team@...roid.com>,
linux-mm <linux-mm@...ck.org>,
linux-arm-kernel@...ts.infradead.org,
linuxppc-dev@...ts.ozlabs.org, x86@...nel.org,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH RESEND 03/28] mm: introduce __find_vma to be used
without mmap_lock protection
On Thu, Sep 1, 2022 at 1:22 PM Kent Overstreet
<kent.overstreet@...ux.dev> wrote:
>
> On Thu, Sep 01, 2022 at 10:34:51AM -0700, Suren Baghdasaryan wrote:
> > Add __find_vma function to be used for VMA lookup under rcu protection.
>
> So it was news to me that the rb tree code can be used for lockless lookups -
> not having looked at lib/rbtree.c in over 10 years :) - I still think it should
> be mentioned in the commit message that that's what you're doing and why it's
> safe, because it's not exactly common knowledge and lockless stuff deserves
> extra scrutiny.
>
> Probably worth a comment, too.
Ack.
>
> Reviewed-by: Kent Overstreet <kent.overstreet@...ux.dev>
Thanks!
>
> --
> To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@...roid.com.
>
Powered by blists - more mailing lists