linux-kernel - Re: [PATCH] scsi: megaraid: remove redundant assignment to variable mfiStatus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166200877447.26143.1705682951642194017.b4-ty@oracle.com>
Date:   Thu,  1 Sep 2022 01:12:47 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     linux-scsi@...r.kernel.org,
        Colin Ian King <colin.i.king@...il.com>,
        megaraidlinux.pdl@...adcom.com,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>,
        Kashyap Desai <kashyap.desai@...adcom.com>,
        Sumit Saxena <sumit.saxena@...adcom.com>,
        Shivasharan S <shivasharan.srikanteshwara@...adcom.com>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] scsi: megaraid: remove redundant assignment to variable mfiStatus

On Fri, 5 Aug 2022 12:50:42 +0100, Colin Ian King wrote:

> The variable mfiStatus is assigned a value but it is never read. The
> assignment is redundant and can be removed. Also remove { } as the
> return statement does not need to be in it's own code block.
> 
> Cleans up clang scan build warning:
> drivers/scsi/megaraid/megaraid_sas_base.c:4026:7: warning: Although the
> value stored to 'mfiStatus' is used in the enclosing expression, the
> value is never actually read from 'mfiStatus' [deadcode.DeadStores]
> 
> [...]

Applied to 6.1/scsi-queue, thanks!

[1/1] scsi: megaraid: remove redundant assignment to variable mfiStatus
      https://git.kernel.org/mkp/scsi/c/4e62671a9a49

-- 
Martin K. Petersen	Oracle Linux Engineering