linux-kernel - Re: [PATCH] scsi: csiostor: convert sysfs snprintf to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220901085114.4a6a5a99@carlis-virtual-machine>
Date:   Thu, 1 Sep 2022 08:51:14 +0800
From:   <zhangxuezhi3@...il.com>
To:     Damien Le Moal <damien.lemoal@...nsource.wdc.com>
Cc:     jejb@...ux.ibm.com, martin.petersen@...cle.com, bvanassche@....org,
        johannes.thumshirn@....com, himanshu.madhani@...cle.com,
        zhangxuezhi1@...lpad.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: csiostor: convert sysfs snprintf to sysfs_emit

On Thu, 1 Sep 2022 09:23:58 +0900
Damien Le Moal <damien.lemoal@...nsource.wdc.com> wrote:

> On 8/31/22 23:10, Xuezhi Zhang wrote:
> > From: Xuezhi Zhang <zhangxuezhi1@...lpad.com>
> > 
> > Fix up all sysfs show entries to use sysfs_emit
> > 
> > Signed-off-by: Xuezhi Zhang <zhangxuezhi1@...lpad.com>
> > ---
> >  drivers/scsi/csiostor/csio_scsi.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/scsi/csiostor/csio_scsi.c
> > b/drivers/scsi/csiostor/csio_scsi.c index
> > 9aafe0002ab1..39e8c3c26a19 100644 ---
> > a/drivers/scsi/csiostor/csio_scsi.c +++
> > b/drivers/scsi/csiostor/csio_scsi.c @@ -1366,9 +1366,9 @@
> > csio_show_hw_state(struct device *dev, struct csio_hw *hw =
> > csio_lnode_to_hw(ln); 
> >  	if (csio_is_hw_ready(hw))
> > -		return snprintf(buf, PAGE_SIZE, "ready\n");
> > +		return sysfs_emit(buf, "ready\n");
> >  	else  
> 
> While at it, you could remove this useless else here.
> 
> > -		return snprintf(buf, PAGE_SIZE, "not ready\n");
> > +		return sysfs_emit(buf,  "not ready\n");  
> 
> Extra space after the ",".
Hi,
  OK, I see.

Thanks.
> 
> >  }
> >  
> >  /* Device reset */
> > @@ -1430,7 +1430,7 @@ csio_show_dbg_level(struct device *dev,
> >  {
> >  	struct csio_lnode *ln = shost_priv(class_to_shost(dev));
> >  
> > -	return snprintf(buf, PAGE_SIZE, "%x\n",
> > ln->params.log_level);
> > +	return sysfs_emit(buf, "%x\n", ln->params.log_level);
> >  }
> >  
> >  /* Store debug level */
> > @@ -1476,7 +1476,7 @@ csio_show_num_reg_rnodes(struct device *dev,
> >  {
> >  	struct csio_lnode *ln = shost_priv(class_to_shost(dev));
> >  
> > -	return snprintf(buf, PAGE_SIZE, "%d\n",
> > ln->num_reg_rnodes);
> > +	return sysfs_emit(buf, "%d\n", ln->num_reg_rnodes);
> >  }
> >  
> >  static DEVICE_ATTR(num_reg_rnodes, S_IRUGO,
> > csio_show_num_reg_rnodes, NULL);  
>