linux-kernel - Re: [PATCH net] net/smc: Remove redundant refcount increase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4c368d3-d293-10e8-1089-5a2654735e15@linux.ibm.com>
Date:   Thu, 1 Sep 2022 07:42:13 +0200
From:   Wenjia Zhang <wenjia@...ux.ibm.com>
To:     liuyacan@...p.netease.com
Cc:     linux-s390@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        kgraul@...ux.ibm.com, Jan Karcher <jaka@...ux.ibm.com>
Subject: Re: [PATCH net] net/smc: Remove redundant refcount increase



On 29.08.22 16:53, liuyacan@...p.netease.com wrote:
> From: liuyacan <liuyacan@...p.netease.com>
> 
> For passive connections, the refcount increment has been done in
> smc_clcsock_accept()-->smc_sock_alloc().
> 
> Fixes: 3b2dec2603d5("net/smc: restructure client and server code in af_smc")
> Signed-off-by: liuyacan <liuyacan@...p.netease.com>
> ---
>   net/smc/af_smc.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/net/smc/af_smc.c b/net/smc/af_smc.c
> index 79c1318af..0939cc3b9 100644
> --- a/net/smc/af_smc.c
> +++ b/net/smc/af_smc.c
> @@ -1855,7 +1855,6 @@ static void smc_listen_out_connected(struct smc_sock *new_smc)
>   {
>   	struct sock *newsmcsk = &new_smc->sk;
>   
> -	sk_refcnt_debug_inc(newsmcsk);
>   	if (newsmcsk->sk_state == SMC_INIT)
>   		newsmcsk->sk_state = SMC_ACTIVE;
>   
Good catch! Thank you for the patch! But fixes should go to the net-next 
tree.