linux-kernel - Re: [PATCH v2] comedi: sysfs: convert sysfs snprintf to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220901090508.4f3a6903@carlis-virtual-machine>
Date:   Thu, 1 Sep 2022 09:05:08 +0800
From:   <zhangxuezhi3@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     abbotti@....co.uk, hsweeten@...ionengravers.com,
        zhangxuezhi1@...lpad.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] comedi: sysfs: convert sysfs snprintf to sysfs_emit

On Wed, 31 Aug 2022 16:02:11 +0200
Greg KH <gregkh@...uxfoundation.org> wrote:

> On Wed, Aug 31, 2022 at 08:55:20PM +0800, Xuezhi Zhang wrote:
> > From: zhangxuezhi1 <zhangxuezhi1@...lpad.com>
> > 
> > Fix up all sysfs show entries to use sysfs_emit  
> 
> This says "what", but not "why".
> 
> Please read the kernel documentation for how to write a good changelog
> text.
> 
> > 
> > Signed-off-by: Xuezhi Zhang <zhangxuezhi1@...lpad.com>
> > ---
> > v2: use a proper name for the Signed-off-by line.  
> 
> Does not match the From: line :(
> 
> 
> thanks,
> 
> greg k-h

OK, I see.

Thanks.