linux-kernel - RE: [PATCH] x86/acrn: Set up timekeeping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB6153FFD6B1D6996EAAAE1F5BBF7B9@SJ1PR11MB6153.namprd11.prod.outlook.com>
Date:   Thu, 1 Sep 2022 07:02:51 +0000
From:   "Li, Fei1" <fei1.li@...el.com>
To:     "Hansen, Dave" <dave.hansen@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "x86@...nel.org" <x86@...nel.org>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "hpa@...or.com" <hpa@...or.com>, "Wang, Yu1" <yu1.wang@...el.com>,
        "Chen, Conghui" <conghui.chen@...el.com>,
        "Yin, Fengwei" <fengwei.yin@...el.com>
Subject: RE: [PATCH] x86/acrn: Set up timekeeping

> On 8/3/22 22:59, Fei Li wrote:
> > +static inline unsigned long acrn_get_tsc_khz(void) {
> > +   return cpuid_eax(ACRN_CPUID_TIMING_INFO);
> > +}
> > +
> >  /*
> >   * Hypercalls for ACRN
> >   *
> > diff --git a/arch/x86/kernel/cpu/acrn.c b/arch/x86/kernel/cpu/acrn.c
> > index 23f5f27b5a02..485441b7f030 100644
> > --- a/arch/x86/kernel/cpu/acrn.c
> > +++ b/arch/x86/kernel/cpu/acrn.c
> > @@ -28,6 +28,9 @@ static void __init acrn_init_platform(void)  {
> >     /* Setup the IDT for ACRN hypervisor callback */
> >     alloc_intr_gate(HYPERVISOR_CALLBACK_VECTOR,
> > asm_sysvec_acrn_hv_callback);
> > +
> > +   x86_platform.calibrate_tsc = acrn_get_tsc_khz;
> > +   x86_platform.calibrate_cpu = acrn_get_tsc_khz;
> >  }
>
> Could you take a sec and consider what 'static inline' does and means and also what setting:
>
>       x86_platform.calibrate_cpu = acrn_get_tsc_khz;
>
> does?
>
> Using 'static inline' might compile, but it doesn't make sense.
>
Hi Dave

Thanks for your reply.
Yes, 'inline' doesn't make sense here.
Now this commit has been merged into the x86/platform branch of tip,
I will send a patch to remove 'inline' once this commit has been merged
into the master branch.

Thanks again.