linux-kernel - Re: [PATCH] mm: remove BUG_ON() in __isolate_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <584e63c2-2574-ea2b-55c4-da5e2cd08868@huawei.com>
Date:   Thu, 1 Sep 2022 16:00:26 +0800
From:   Kefeng Wang <wangkefeng.wang@...wei.com>
To:     David Hildenbrand <david@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>, <linux-mm@...ck.org>
CC:     <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm: remove BUG_ON() in __isolate_free_page()


On 2022/9/1 15:37, David Hildenbrand wrote:
> On 01.09.22 03:50, Kefeng Wang wrote:
>> Drop unneed comment and blank, adjust the variable, and the most
>> important is to delete BUG_ON(). The page passed is always buddy
>> page into __isolate_free_page() from compaction, page_isolation
>> and page_reporting, and the caller also check the return, BUG_ON()
>> is a too drastic measure, remove it.
> Why not WARN_ON_ONCE then? But yeah, maybe this really isn't of any
> value anymore.

or VM_WARN_ON()， but I think this bug_on is useless after check all 
calllers,

so let's drop it if no objection.